Gamestate to POD#47
Conversation
Coverage ReportNo coverage data available. |
aliceagain
force-pushed
the
gamestate_to_pod
branch
from
1c77497 to
bbbf0bc
Compare
|
aliceagain
force-pushed
the
gamestate_to_pod
branch
11 times, most recently
from
2a42c09 to
0b40a35
Compare
aliceagain
force-pushed
the
gamestate_to_pod
branch
5 times, most recently
from
a4e0df4 to
ef21acc
Compare
aliceagain
force-pushed
the
gamestate_to_pod
branch
from
ef21acc to
c1917b7
Compare
ChristopherJMiller
left a comment
ChristopherJMiller
left a comment
There was a problem hiding this comment.
I think everything lgtm! My understanding of the strategy is moving everything to be simple data inputs to produce mutations, instead of state + arbitrary indicator (like player slot) to calculate everything, which lets us generalize a bunch of things much better!
Found a very small nit that might be completely moot
| state->concealedKan = false; | ||
| state->turnNum++; | ||
|
|
||
| Hand& hand = state->hands[state->currentPlayer]; |
There was a problem hiding this comment.
nit: is this technically a double array access with the if statement above?
There was a problem hiding this comment.
We update state->currentPlayer to state->lastCaller on line 38. So it's accessing a diff player now.
|
And this is more about having the gamestate contain all of the state in one location instead of having additional heap allocations. Which means you can just memcpy the object itself without having to worry about it pointing to heap data. It's not fully there but I have follow up stuff. Need to get the big diff out first tho. |
2 participants
No description provided.