feat: allow to pass in relative paths for input files and add assets file - #1
Conversation
|
I can confirm this works, probably the easiest wat to fix this as you need authentication for the download, authentication could be something for down the road. Edit: |
|
@Joshi234 I didn't really understand what you meant, could you rephrase ? |
|
I believe the only observation he had is that the "plugins" folder where the user's plugin is being copied to should be named mods instead for it to work with the hytale jar. It doesn't have anything to do with the PR tho. |
Yeah that and the server jar needs to be set as dependency in the gradle so you can actually write plugins in build.gradle.kts While thoes fixed doen't relate directly to your pr, it would be nice if you could commit them to make this template usable with this pr |
Adjusted the paths in build.gradle.kts to reference the correct locations for HytaleServer.jar and Assets.zip. Updated README to reflect changes in the server's mods folder instead of plugins folder for clarity.
|
I updated the PR with the renaming to |
| // Hytale API (provided by server) | ||
| compileOnly(files("libs/hytale-server.jar")) | ||
| compileOnly(files("./HytaleServer.jar")) |
There was a problem hiding this comment.
Is it expected to have ./HytaleServer.jar here while in other places it is at ./libs/HytaleServer.jar ?
There was a problem hiding this comment.
It turns out that in the build.gradle.kts file, there is the following path: "./libs/HytaleServer.jar".
) * Enhance build configuration and dependencies for Hytale plugin to use HytaleServer.jar from official maven repository. Added permissions in workflows to allow github action to create new releases. * Remove unused database driver dependencies Removed unused database driver dependencies. --------- Co-authored-by: Federico Leiva <fl8176@gmail.com> Co-authored-by: InvBoy <49959270+FedericoLeiva12@users.noreply.github.com>

Issue
The
gradlew runServerdoesn't pass in theAssets.zipfile as a parameter, which causes the server to crash.Solution
I added a property in the build.gradle.kts to allow the user to pass in the Assets.zip location so it's used.
Bonus
I also made the two fields be able to accept either URLs, relative, or absolute paths.