Stop showing white canvas element at the top#4
Open
Balvald wants to merge 1 commit into
Open
Conversation
The selection into the app was misaligned by the exact amount of pixels that the white canvas element had in height that showed at the top of the application. This change just hides this canvas container so that the three dimensional scene properly takes up all of the inner window space. The intersection tests between the click position and the 3d objects (the ones that happen in SceneInit.js in onWindowClicked()) assume that the scene takes up the whole inner window space. This means if this white canvas element I'm hiding with this change really needs to be shown (for whatever reason that I may be unaware of) I'd implore to adjust the "onWindowClicked()" function in SceneInit.js accordingly (though that'd be a lot more work) So that the position where we have to click is properly aligned with the object that we want to select.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selection into the app was misaligned by the exact amount of pixels that the white canvas element had in height that showed at the top of the application.
This change just hides this canvas container so that the three dimensional scene properly takes up all of the inner window space.
The intersection tests between the click position and the 3d objects (the ones that happen in SceneInit.js in onWindowClicked()) assume that the scene takes up the whole inner window space.