Skip to content

[Obsidian] Handle Expired Account Errors#94

Merged
rasulkireev merged 6 commits into
masterfrom
codex/obsidian-expired-account-error
May 14, 2026
Merged

[Obsidian] Handle Expired Account Errors#94
rasulkireev merged 6 commits into
masterfrom
codex/obsidian-expired-account-error

Conversation

@rasulkireev

@rasulkireev rasulkireev commented May 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Detect the structured expired-account response from the Obsidian API: error: "account_expired".
  • Show the API-provided message in the normal Obsidian notice/status UI, with a small fallback message if the response omits one.
  • Keep the UX intentionally small: no modal and no extra upgrade link.
  • Move response error parsing into a small testable helper and add focused tests for the account-expired behavior.
  • Prepare release 3.0.3 by updating package.json, package-lock.json, manifest.json, versions.json, and the plugin client version constant.

Backend dependency

This expects the backend response from readwiseio/rekindled#9358:

{
  "error": "account_expired",
  "message": "...",
  "upgrade_url": "..."
}

Release

After this PR merges, create and push tag 3.0.3 to run the existing release workflow. The workflow builds the plugin and creates a draft GitHub release with main.js, manifest.json, and styles.css.

Validation

  • npm test
  • npm run ci

The build passes. It still prints the existing non-fatal dotenv preventAssignment warning.

@rasulkireev
rasulkireev marked this pull request as ready for review May 14, 2026 14:13
@rasulkireev
rasulkireev force-pushed the codex/obsidian-expired-account-error branch from a5ac062 to 5f1fa8c Compare May 14, 2026 14:37
@rasulkireev
rasulkireev merged commit cc37681 into master May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant