feat: add poo/value_objects#15
Open
Emalios wants to merge 21 commits into
Open
Conversation
AntoineJT
force-pushed
the
value-objects-fr
branch
from
August 9, 2020 17:15
6d67ea5 to
76dcb83
Compare
LukaMrt
suggested changes
Aug 9, 2020
Co-authored-by: LukaMrt <48085295+LukaMrt@users.noreply.github.com>
Emalios
commented
Aug 9, 2020
Emalios
left a comment
Emalios
left a comment
Contributor
Author
There was a problem hiding this comment.
Resolve all requests
LukaMrt
previously approved these changes
Aug 10, 2020
LukaMrt
previously approved these changes
Aug 10, 2020
Tran-Antoine
requested changes
Aug 10, 2020
Member
There was a problem hiding this comment.
Bonnes explications !
Seule remarque, je trouve un peu dommage de ne pas mettre en avant les avantages des value objects. Ils sont bien définis, expliqués et exemplifiés, mais tu ne dis nulle part à quoi ils servent, en gros pourquoi éviter la primitive obsession. Peut-être un paragraphe supplémentaire à ajouter dans une future PR ?
Emalios
commented
Aug 10, 2020
Emalios
left a comment
Emalios
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewing changes
Co-authored-by: Antoine Tran <31257370+Tran-Antoine@users.noreply.github.com>
Co-authored-by: Antoine Tran <31257370+Tran-Antoine@users.noreply.github.com>
AntoineJT
requested changes
Aug 12, 2020
AntoineJT
left a comment
AntoineJT
left a comment
Member
There was a problem hiding this comment.
Il y a quelques trucs qui me paraissent bizarres :
- le fait que tu parles de 2 caractéristiques principales mais que le document soit centré autour de 3 caractéristiques ;
- la conclusion qui n'est qu'un regroupement des 3 caractéristiques.
Je pense que pour la conclusion tu pourrais vite fait expliquer à quoi sert un value object en définitive, un peu comme un tl;dr quoi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.