Skip to content

Use separate privacy bundle name to avoid conflicts with standalone ZIPFoundation#14

Merged
mickael-menu merged 1 commit into
readium:developfrom
aaronleopold:develop
Nov 6, 2025
Merged

Use separate privacy bundle name to avoid conflicts with standalone ZIPFoundation#14
mickael-menu merged 1 commit into
readium:developfrom
aaronleopold:develop

Conversation

@aaronleopold

Copy link
Copy Markdown

When using both ReadiumZIPFoundation (this fork) and the standalone ZIPFoundation pod in the same project, Xcode fails to build with the following error:

Multiple commands produce '/path/to/DerivedData/.../ZIPFoundation_Privacy.bundle'

Changes proposed in this PR

  • Rename the privacy bundle to ReadiumZIPFoundation_Privacy

Further info for the reviewer

A workaround I had to implement was to manually delete the ZIPFoundation-ZIPFoundation_Privacy target in a CocoaPods post_install hook and patch the generated copy scripts to remove references to the deleted bundle.

If the privacy bundle was just renamed to align with the fork's name, this is not needed

@mickael-menu mickael-menu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you for this fix.

@mickael-menu mickael-menu merged commit 68495f2 into readium:develop Nov 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants