Skip to content

fix(build)!: honor consumer implicit usings #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glennawatson merged 1 commit into from
Oct 12, 2026
Merged

fix(build)!: honor consumer implicit usings #4539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/ReactiveUI.Reactive/buildTransitive/ReactiveUI.Reactive.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project>
<!-- The binding engine's namespaces are imported for every consumer, so calls such as WhenAnyValue,
ObservableForProperty, Bind and BindCommand, and the view locator, resolve without a using directive. -->
<ItemGroup>
<!-- Import the binding engine's namespaces when the consumer enables implicit usings. -->
<ItemGroup Condition="'$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable'">
<Using Include="ReactiveUI.Binding.Reactive" />
<Using Include="ReactiveUI.Binding.Reactive.ObservableForProperty" />
</ItemGroup>
Expand Down
5 changes: 2 additions & 3 deletions src/ReactiveUI.Wpf.Reactive/buildTransitive/ReactiveUI.Wpf.Reactive.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project>
<!-- The WPF binding types, such as BooleanToVisibilityTypeConverter and BooleanToVisibilityHints, come from
ReactiveUI.Binding.Wpf.Reactive, so their namespace is imported for every consumer. -->
<ItemGroup>
<!-- Import the WPF binding types' namespace when the consumer enables implicit usings. -->
<ItemGroup Condition="'$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable'">
<Using Include="ReactiveUI.Binding.Reactive.Wpf" />
</ItemGroup>
</Project>
5 changes: 2 additions & 3 deletions src/ReactiveUI.Wpf/buildTransitive/ReactiveUI.Wpf.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project>
<!-- The WPF binding types, such as BooleanToVisibilityTypeConverter and BooleanToVisibilityHints, come from
ReactiveUI.Binding.Wpf, so their namespace is imported for every consumer. -->
<ItemGroup>
<!-- Import the WPF binding types' namespace when the consumer enables implicit usings. -->
<ItemGroup Condition="'$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable'">
<Using Include="ReactiveUI.Binding.Wpf" />
</ItemGroup>
</Project>
5 changes: 2 additions & 3 deletions src/ReactiveUI/buildTransitive/ReactiveUI.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project>
<!-- The binding engine's namespaces are imported for every consumer, so calls such as WhenAnyValue,
ObservableForProperty, Bind and BindCommand, and the view locator, resolve without a using directive. -->
<ItemGroup>
<!-- Import the binding engine's namespaces when the consumer enables implicit usings. -->
<ItemGroup Condition="'$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable'">
<Using Include="ReactiveUI.Binding" />
<Using Include="ReactiveUI.Binding.ObservableForProperty" />
</ItemGroup>
Expand Down
Loading