Modernize Storybook docs with a11y gating and interaction coverage - #8
Merged
Conversation
Adopt Storybook 10 project defaults (autodocs, code panel, a11y error), portable story mounts in rstest, and a CI test-runner job so overlays and play functions are exercised in a real browser. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 5842c59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Give ScrollArea viewports tabindex=0, name the Popover dialog in docs, and disable aria-hidden-focus for intentional open Select/Menu states (Radix hides #storybook-root while the trigger remains focusable). Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2227803. Configure here.
The dev server uses assetPrefix `/`, so the `/silk/` suffix only applies to production builds, which test:storybook:ci already serves accordingly. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autodocs,docs.codePanel, anda11y.test: 'error'@storybook/test-runner(served under/silk/to match GitHub PagesassetPrefix)Test plan
yarn typecheckyarn testyarn docs:buildyarn test:storybook(or wait for theStorybook TestCI job)Made with Cursor