Repository navigation
[ImageBackground] Forward aria-hidden and accessibilityElementsHidden to wrapper View - #59808
Open
GautamKumarOffical wants to merge 1 commit into
Open
GautamKumarOffical wants to merge 1 commit into
GautamKumarOffical wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #59746.
ImageBackgroundrenders its children inside a wrapperViewalongside theImagecomponent. Previously,importantForAccessibilitywas forwarded to both the wrapperViewand the innerImage, butaria-hiddenandaccessibilityElementsHiddenwere only passed along via...propsto the innerImage. Consequently, settingaria-hidden={true}on anImageBackgroundleft its rendered children exposed in the accessibility tree on both iOS and Android.This change explicitly forwards
aria-hiddenandaccessibilityElementsHiddento the wrapperView(in addition to the innerImage), ensuring children are correctly hidden from accessibility services.Changelog:
[GENERAL] [FIXED] - Forward aria-hidden and accessibilityElementsHidden to ImageBackground wrapper View
Test Plan:
packages/react-native/Libraries/Image/__tests__/ImageBackground-itest.jsasserting thataria-hiddenis propagated to both the wrapperViewand the innerImage.