Repository navigation
Name unnamed parameters in function type annotations (#59790) - #59790
Merged
Merged
Conversation
|
@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129441819. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Nov 4, 2026
Summary: Pull Request resolved: #59790 Gives every unnamed parameter in a Flow function type annotation a name: `v` for a lone parameter, `v<index>` otherwise, and `rest` for a rest parameter. Type-only change with no runtime behavior change. Changelog: [Internal] Reviewed By: panagosg7 Differential Revision: D129441819
meta-codesync
Bot
force-pushed
the
export-D129441819
branch
from
November 4, 2026 18:43
6e3c4b7 to
3a01d24
Compare
Collaborator
|
This pull request was successfully merged by @SamChou19815 in 3a01d24 When will my fix make it into a release? | How to file a pick request? |
Summary: Pull Request resolved: #59790 Gives every unnamed parameter in a Flow function type annotation a name: `v` for a lone parameter, `v<index>` otherwise, and `rest` for a rest parameter. Type-only change with no runtime behavior change. Changelog: [Internal] Reviewed By: panagosg7 Differential Revision: D129441819
meta-codesync
Bot
force-pushed
the
export-D129441819
branch
from
November 4, 2026 19:14
3a01d24 to
8b96108
Compare
Collaborator
|
This pull request was successfully merged by @SamChou19815 in 8b96108 When will my fix make it into a release? | How to file a pick request? |
Collaborator
|
This pull request was successfully merged by @SamChou19815 in 38f6e19 When will my fix make it into a release? | How to file a pick request? |
meta-codesync Bot
pushed a commit
to react/metro
that referenced
this pull request
Nov 4, 2026
Summary: X-link: react/react-native#59790 Gives every unnamed parameter in a Flow function type annotation a name: `v` for a lone parameter, `v<index>` otherwise, and `rest` for a rest parameter. Type-only change with no runtime behavior change. Changelog: [Internal] Reviewed By: panagosg7 Differential Revision: D129441819 Pull Request resolved: #2169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Gives every unnamed parameter in a Flow function type annotation a name:
vfor a lone parameter,v<index>otherwise, andrestfor a rest parameter. Type-only change with no runtime behavior change.Changelog: [Internal]
Reviewed By: panagosg7
Differential Revision: D129441819