Skip to content

Name unnamed parameters in function type annotations (#59790) - #59790

Merged
meta-codesync[bot] merged 1 commit into
mainfrom
export-D129441819
Nov 4, 2026
Merged

meta-codesync[bot] merged 1 commit into
mainfrom
export-D129441819

Conversation

@SamChou19815

@SamChou19815 SamChou19815 commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Summary:

Gives every unnamed parameter in a Flow function type annotation a name: v for a lone parameter, v<index> otherwise, and rest for a rest parameter. Type-only change with no runtime behavior change.

Changelog: [Internal]

Reviewed By: panagosg7

Differential Revision: D129441819

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2026
@facebook-github-tools facebook-github-tools Bot added p: Facebook Partner: Facebook Partner labels Nov 3, 2026
@meta-codesync

meta-codesync Bot commented Nov 3, 2026

Copy link
Copy Markdown

@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129441819.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: POTENTIALLY_BREAKING

meta-codesync Bot pushed a commit that referenced this pull request Nov 4, 2026
Summary:
Pull Request resolved: #59790

Gives every unnamed parameter in a Flow function type annotation a name: `v` for a lone parameter, `v<index>` otherwise, and `rest` for a rest parameter. Type-only change with no runtime behavior change.

Changelog: [Internal]

Reviewed By: panagosg7

Differential Revision: D129441819
@meta-codesync meta-codesync Bot changed the title Name unnamed parameters in function type annotations Name unnamed parameters in function type annotations (#59790) Nov 4, 2026
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @SamChou19815 in 3a01d24

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 4, 2026
Summary:
Pull Request resolved: #59790

Gives every unnamed parameter in a Flow function type annotation a name: `v` for a lone parameter, `v<index>` otherwise, and `rest` for a rest parameter. Type-only change with no runtime behavior change.

Changelog: [Internal]

Reviewed By: panagosg7

Differential Revision: D129441819
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @SamChou19815 in 8b96108

When will my fix make it into a release? | How to file a pick request?

@meta-codesync
meta-codesync Bot merged commit 38f6e19 into main Nov 4, 2026
30 of 31 checks passed
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @SamChou19815 in 38f6e19

When will my fix make it into a release? | How to file a pick request?

meta-codesync Bot pushed a commit to react/metro that referenced this pull request Nov 4, 2026
Summary:
X-link: react/react-native#59790

Gives every unnamed parameter in a Flow function type annotation a name: `v` for a lone parameter, `v<index>` otherwise, and `rest` for a rest parameter. Type-only change with no runtime behavior change.

Changelog: [Internal]

Reviewed By: panagosg7

Differential Revision: D129441819

Pull Request resolved: #2169
@SamChou19815
SamChou19815 deleted the export-D129441819 branch November 4, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants