Repository navigation
Pause RNTester visual regression checks on pull requests - #59629
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
cortinico
marked this pull request as ready for review
October 29, 2026 15:28
Contributor
Author
|
cc @robhogan as this would have to be reverted at some point |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D128344811. |
cortinico
enabled auto-merge (squash)
October 29, 2026 15:30
cipolleschi
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Temporarily skip RNTester visual regression captures and follow-up comparison for pull requests, including fork PRs. Keep capture, comparison, and baseline publication running on pushes to main. This is a separate branch based on main, not on the Maestro Cloud cleanup PR.
Changelog:
[INTERNAL] [CHANGED] - Pause visual regression checks on pull requests while retaining mainline baseline updates.
Test Plan:
git diff --check— passed.ruby -e 'require "yaml"; %w[.github/workflows/test-all.yml .github/workflows/visual-compare-rntester.yml].each { |file| YAML.parse_file(file); puts "OK #{file}" }'— parsed both workflows successfully.test_visual_ios_rntester,test_visual_android_rntester, andfind_capturesjob conditions — confirmed both captures require a main push and comparisons require a push, not a pull request.