Skip to content

Delete stub RCTAppSetupDefaultJsExecutorFactory (#59435) #59435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Oct 30, 2026
+7 −26
Merged

Delete stub RCTAppSetupDefaultJsExecutorFactory (#59435) #59435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,32 +6,21 @@
*/

#import <Foundation/Foundation.h>
#import <React/RCTBridge.h>
#import <React/RCTRootView.h>

#ifdef __cplusplus
@class RCTBridge;
@class RCTRootView;

#import <memory>
#ifdef __cplusplus

#import <ReactCommon/RCTTurboModuleManager.h>

@protocol RCTDependencyProvider;

// Forward declaration to decrease compilation coupling
namespace facebook::react {
class JSExecutorFactory;
class RuntimeScheduler;
} // namespace facebook::react
RCT_EXTERN NSArray<NSString *> *RCTAppSetupUnstableModulesRequiringMainQueueSetup(
id<RCTDependencyProvider> dependencyProvider);

RCT_EXTERN id<RCTTurboModule> RCTAppSetupDefaultModuleFromClass(
Class moduleClass,
id<RCTDependencyProvider> dependencyProvider);

std::unique_ptr<facebook::react::JSExecutorFactory> RCTAppSetupDefaultJsExecutorFactory(
RCTBridge *bridge,
RCTTurboModuleManager *turboModuleManager,
const std::shared_ptr<facebook::react::RuntimeScheduler> &runtimeScheduler);

#endif // __cplusplus
12 changes: 0 additions & 12 deletions packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@

#import "RCTAppSetupUtils.h"

#import <cxxreact/JSExecutor.h>
#import <react/renderer/runtimescheduler/RuntimeScheduler.h>
#import <react/renderer/runtimescheduler/RuntimeSchedulerBinding.h>

// Turbo Module
#import <React/RCTBundleAssetImageLoader.h>
#import <React/RCTDataRequestHandler.h>
Expand Down Expand Up @@ -92,11 +88,3 @@
// No custom initializer here.
return [moduleClass new];
}

std::unique_ptr<facebook::react::JSExecutorFactory> RCTAppSetupDefaultJsExecutorFactory(
RCTBridge *bridge,
RCTTurboModuleManager *turboModuleManager,
const std::shared_ptr<facebook::react::RuntimeScheduler> &runtimeScheduler)
{
return nullptr;
}
4 changes: 4 additions & 0 deletions packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/

#import "RCTDefaultReactNativeFactoryDelegate.h"
#import <React/RCTRootView.h>
#import <ReactCommon/RCTHost.h>
#import "RCTAppSetupUtils.h"
#import "RCTDependencyProvider.h"
Expand Down Expand Up @@ -47,10 +48,13 @@ - (JSRuntimeFactoryRef)createJSRuntimeFactory
#endif
}

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
- (void)customizeRootView:(RCTRootView *)rootView
{
// Override point for customization after application launch.
}
#pragma clang diagnostic pop

- (RCTColorSpace)defaultColorSpace
{
Expand Down
Loading