Repository navigation
Fix MountItemDispatcherTest compilation after pullTransaction was added - #59393
Closed
cipolleschi wants to merge 1 commit into
Closed
cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
react#57164 added `RecordingItemDispatchListener` to `MountItemDispatcherTest`, but react#59029 had added an abstract `pullTransaction(surfaceId: Int)` to `MountItemDispatcher.ItemDispatchListener` in the meantime. Each change was green on its own; combined, `compileDebugUnitTestKotlin` fails on main and breaks `build_android`. Implement `pullTransaction` as a no-op in the test listener, matching the other callbacks it doesn't need to record.
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D127134507. |
Visual regressionNo visual differences at ios: no capture |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 097bcce When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
build_androidis red onmainbecause the ReactAndroid unit tests no longer compile:Two changes that were each green on their own collided:
pullTransaction(surfaceId: Int)toMountItemDispatcher.ItemDispatchListener.RecordingItemDispatchListenertoMountItemDispatcherTest. That branch was cut before Pull model: pull each surface's pending transaction at the start of the mount phase (#59029) #59029, so the listener doesn't implement the new method.This PR implements
pullTransactionas a no-op in the test listener. The listener already does the same for the other callbacks the tests don't record (willMountItems,didMountItems,onItemsQueued). Production code doesn't change.Changelog:
[INTERNAL] [FIXED] - Fix MountItemDispatcherTest compilation
Test Plan:
main, for example in run https://github.com/react/react-native/actions/runs/39902319109 (build_android). It has been failing since the main run for 0876643.FabricUIManageris the only otherItemDispatchListenerimplementation, and it already overridespullTransaction, so the test listener is the only implementation missing it.yarn installfails. Thebuild_androidjob on this PR runs exactly the failingcompileDebugUnitTestKotlintask and verifies the fix.