Skip to content

Pass the clip rect through iOS views that don't clip subviews #59246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hryhoriiK97 wants to merge 1 commit into from
Closed

Pass the clip rect through iOS views that don't clip subviews #59246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/react-native/React/Fabric/Mounting/UIView+ComponentViewProtocol.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,12 @@ - (void)setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:(nullable NSSet<N

- (void)updateClippedSubviewsWithClipRect:(CGRect)clipRect relativeToView:(UIView *)clipView
{
clipRect = [clipView convertRect:clipRect toView:self];

// Normal views don't support unmounting, so all
// this does is forward message to our subviews,
// in case any of those do support it
// in case any of those do support it. The rect stays relative to `clipView`;
// a view that clips converts it to its own coordinates.
for (UIView *subview in self.subviews) {
[subview updateClippedSubviewsWithClipRect:clipRect relativeToView:self];
[subview updateClippedSubviewsWithClipRect:clipRect relativeToView:clipView];
}
}

Expand Down
Loading