Repository navigation
Conversation
cipolleschi
approved these changes
Oct 21, 2026
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
thanks for fixing this.
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D126658662. |
Contributor
|
@mrousavy the test_js signals are failing in CI. Can you have a look at them and fix them? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Xcode warns that
Sync SPM Autolinkingruns on every build because the generated phase has no declared outputs. The script intentionally checks its own stamp and dynamically discovered inputs on every build, then skips regeneration when they are unchanged.Set
alwaysOutOfDate = 1when creating or updating this phase. Existing projects receive the setting on their nextspm update. Plugin phases keep their own dependency-analysis settings.Changelog:
[IOS] [FIXED] - Remove the missing-output warning from the generated SPM autolinking sync phase.
Test Plan:
inject-spm-xcodeproj-test.js,generate-spm-xcodeproj-test.jsandremove-spm-injection-test.js, run with--runInBand,testEnvironment: "node"andtransform: {}. This includes the script's existing stamp checks, injection/removal and plugin-phase reconciliation tests.prettier@3.9.4 --checkon the three changed files andgit diff --checkpassed.No native app build was run for this project-generation change.