Skip to content

Derive multiline TextInput state from props (#59218) #59218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cipolleschi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Derive multiline TextInput state from props (#59218) #59218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .../react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ - (void)reactUpdateResponderOffsetForScrollView:(RCTScrollViewComponentView *)sc
} else {
// Focus on text selection frame
focusRect = selection.rect;
BOOL isMultiline = [_backedTextInputView isKindOfClass:[UITextView class]];
BOOL isMultiline = _props ? static_cast<const TextInputProps &>(*_props).multiline
: [_backedTextInputView isKindOfClass:[UITextView class]];
if (!isMultiline) {
focusRect.size.height += kSingleLineKeyboardBottomOffset;
}
Expand Down Expand Up @@ -859,7 +860,8 @@ - (void)_setAttributedString:(NSAttributedString *)attributedString
// A single-line input that is not being edited has no cursor to keep: UIKit places one when editing begins.
// Restoring it anyway makes UIKit scroll the field editor to it when the text doesn't fit, and the editor keeps
// that offset after the text fits again, so text typed later in this view (also after recycling) is drawn too high.
BOOL isMultiline = [_backedTextInputView isKindOfClass:[UITextView class]];
BOOL isMultiline = _props ? static_cast<const TextInputProps &>(*_props).multiline
: [_backedTextInputView isKindOfClass:[UITextView class]];
if (isMultiline || _backedTextInputView.isFirstResponder) {
// Updating the UITextView attributedText, for example changing the lineHeight, the color or adding
// a new paragraph with \n, causes the cursor to move to the end of the Text and scroll.
Expand Down
Loading