Repository navigation
Mark logger/react_native_log.h as a for-frameworks C++ API - #59105
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
Summary: `react_native_log.h` is how host integrations install a sink for React Native's native logs (`set_react_native_logfunc`, `ReactNativeLogLevel`). It is not reached from any public header, so classify it in the "for frameworks" tier of the C++ stable API by including `FrameworksGuard.h`. Consumers opting into `RN_STRICT_API` get a suppressible warning (silenced with `RN_ALLOW_FRAMEWORKS`) instead of no classification. The `logger` target now depends on `cxxstableapi` in BUCK, CMake and CocoaPods. Changelog: [Internal] Differential Revision: D125412015
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125412015. |
|
This pull request has been merged in 72885c1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
react_native_log.his how host integrations install a sink for React Native's native logs (set_react_native_logfunc,ReactNativeLogLevel). It is not reached from any public header, so classify it in the "for frameworks" tier of the C++ stable API by includingFrameworksGuard.h. Consumers opting intoRN_STRICT_APIget a suppressible warning (silenced withRN_ALLOW_FRAMEWORKS) instead of no classification.The
loggertarget now depends oncxxstableapiin BUCK, CMake and CocoaPods.Changelog: [Internal]
Differential Revision: D125412015