Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
byCedric
force-pushed
the
@bycedric/react-native/add-missing-asset-registry-types
branch
from
October 9, 2026 09:49
f034407 to
50672a7
Compare
Draft
4 of 5 tasks
byCedric
force-pushed
the
@bycedric/react-native/add-missing-asset-registry-types
branch
from
October 9, 2026 09:55
50672a7 to
bb4597f
Compare
facebook-github-tools
Bot
added
the
Shared with Meta
Collaborator
|
We should be able to pick this exact commit to 87 once merged. |
Contributor
Author
|
@huntie it might be slightly harder due to the folder rename in |
byCedric
marked this pull request as draft
October 9, 2026 10:45
…n for better TypeScript handling
byCedric
force-pushed
the
@bycedric/react-native/add-missing-asset-registry-types
branch
from
October 9, 2026 10:46
54c54f6 to
c91c124
Compare
byCedric
marked this pull request as ready for review
October 9, 2026 10:46
This was referenced Oct 9, 2026
Contributor
Author
|
Can we get this merged before |
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D125060242. |
|
@fabriziocucci merged this pull request in b8ec87e. |
fabriziocucci
pushed a commit
that referenced
this pull request
Oct 14, 2026
Summary: #57369 moved the AssetRegistry into the public API of React Native starting from `0.87`. Unfortunately, it seems that the TypeScript types were not updated to include this API, resulting in type issues when trying to use: ```ts import { AssetRegistry, type AssetDestPathResolver, type PackagerAsset } from 'react-native' ``` This PR fixes the typing issues for `0.88`. The [Flow types were updated correctly](https://github.com/react/react-native/blob/2d913c7292088a7bc4482a6febb2ee4903d6f32f/packages/react-native/index.js.flow#L282-L286) in `0.87-rc.0`. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [FIXED] Add missing TypeScript types for public `AssetRegistry` API Pull Request resolved: #58964 Test Plan: - Prepare any TypeScript project with React Native - Run type checks for: `import { AssetRegistry, type AssetDestPathResolver, type PackagerAsset } from 'react-native'` - Should succeed Reviewed By: Abbondanzo Differential Revision: D125060242 Pulled By: fabriziocucci fbshipit-source-id: 4efadb3647afcac43ecd83472a88d9fb02882905 (cherry picked from commit b8ec87e)
byCedric
deleted the
@bycedric/react-native/add-missing-asset-registry-types
branch
October 14, 2026 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#57369 moved the AssetRegistry into the public API of React Native starting from
0.87. Unfortunately, it seems that the TypeScript types were not updated to include this API, resulting in type issues when trying to use:This PR fixes the typing issues for
0.88.The Flow types were updated correctly in
0.87-rc.0.Changelog:
[GENERAL] [FIXED] Add missing TypeScript types for public
AssetRegistryAPITest Plan:
import { AssetRegistry, type AssetDestPathResolver, type PackagerAsset } from 'react-native'