Repository navigation
Add Android opt-in for RN_STRICT_API (#58849) - #58849
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123399797. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets. Changelog: [Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code Differential Revision: D123399797
j-piasecki
force-pushed
the
export-D123399797
branch
from
October 5, 2026 11:24
0bdf940 to
f0c588a
Compare
meta-codesync
Bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Pull Request resolved: react#58849 Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets. Changelog: [Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code Differential Revision: D123399797
j-piasecki
force-pushed
the
export-D123399797
branch
from
October 5, 2026 11:28
f0c588a to
12ff978
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets. Changelog: [Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code Differential Revision: D123399797
j-piasecki
force-pushed
the
export-D123399797
branch
from
October 7, 2026 07:55
12ff978 to
d66cff1
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58849 Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets. Changelog: [Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code Differential Revision: D123399797
j-piasecki
force-pushed
the
export-D123399797
branch
from
October 7, 2026 07:59
d66cff1 to
80ecd14
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58849 Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets. Changelog: [Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code Differential Revision: D123399797
j-piasecki
force-pushed
the
export-D123399797
branch
from
October 7, 2026 10:16
80ecd14 to
a71ea91
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58849 Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets. Changelog: [Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code Differential Revision: D123399797
j-piasecki
force-pushed
the
export-D123399797
branch
from
October 7, 2026 10:34
a71ea91 to
8fedafd
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets. Changelog: [Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code Reviewed By: cipolleschi Differential Revision: D123399797
j-piasecki
force-pushed
the
export-D123399797
branch
from
October 9, 2026 07:49
8fedafd to
3723bb9
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets. Changelog: [Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code Reviewed By: cipolleschi Differential Revision: D123399797
j-piasecki
force-pushed
the
export-D123399797
branch
from
October 9, 2026 07:50
3723bb9 to
3381b91
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: Pull Request resolved: react#58849 Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets. Changelog: [Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code Reviewed By: cipolleschi Differential Revision: D123399797
j-piasecki
force-pushed
the
export-D123399797
branch
from
October 9, 2026 07:54
3381b91 to
53a39f3
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 12, 2026
Summary: Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets. Changelog: [Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code Reviewed By: cipolleschi Differential Revision: D123399797
j-piasecki
force-pushed
the
export-D123399797
branch
from
October 12, 2026 08:35
53a39f3 to
37870c3
Compare
Summary: Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets. Changelog: [Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code Reviewed By: cipolleschi Differential Revision: D123399797
j-piasecki
force-pushed
the
export-D123399797
branch
from
October 12, 2026 10:10
37870c3 to
1bb9cce
Compare
cortinico
approved these changes
Oct 13, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in b5d9b6c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a
strictCxxApiEnabled(orreact.strictCxxApiEnabled) Gradle property that definesRN_STRICT_APIfor an app's own native code: the app library, autolinked libraries and app codegen, throughcommon_flagsinReactNative-application.cmake. React Native's own code is unaffected, since it definesRN_BUILDING. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by#pragma onceand the guards are effectively not enforced in those targets.Changelog:
[Android][Added] - Add
strictCxxApiEnabledGradle property to enforce React Native's C++ stable API in app native codeReviewed By: cipolleschi
Differential Revision: D123399797