[robhogan]

Follow up to #2169, which named every unnamed parameter in Flow function types v, v<index> or rest. This replaces those placeholders with descriptive names, taken from the implementation or call site wherever there is one.

The only change beyond names is dropping two void parameters that are never passed, on resolve in IncrementalBundler and cb in bundle.flow.js.

Changelog: Internal

Test plan:
Compiled each changed file outside flow-typed/ with the repo's Babel config before and after this change, and the output is identical. API snapshots are unchanged.

[github-actions]

Metro review: Looks good

Risk: low · Commit: 0f7e01d · 8 commands run

This PR replaces the v, v<index> and rest placeholders in Flow function types with descriptive names and drops two unused void parameters. Its claims hold: compiled output is identical across all 54 non-flow-typed JS files, and with parameter names erased, ASTs across all 61 changed files differ only in those two void parameters. Flow, TypeScript, lint, formatting and API snapshots pass, and the names I checked against implementations and call sites match, so I have no findings.

No findings.

Verified

• ✅ yarn typecheck — Flow reports no errors on head.
• ✅ yarn typecheck-ts — Passes on head and base. Includes TypeScript definition generation.
• ✅ yarn verify-api-snapshots — 18 snapshots verified, with no API.md changes in the PR.
• ✅ yarn lint
• ✅ yarn format-check
• ✅ node compare-babel.js — Compiled the 54 changed JS files outside flow-typed/ from both checkouts with the repo's Babel config: 0 differ.
• ✅ node compare-ast.js — Parsed all 61 changed files with parameter names erased. Only IncrementalBundler.js and bundle.flow.js differ, at the two dropped void parameters. Reports the first difference per file.
• ✅ yarn jest --no-watchman <changed metro-file-map, HMRClient, Graph and HmrServer tests, plus api-snapshots-sync-test> — 17 suites, 656 tests. Some changed test files were not in this subset.

Not run: No benchmarks: compiled output is byte-identical, so runtime cost can't change. The full Jest suite wasn't run, for the same reason. Windows wasn't tested because the change only touches erased types and no Windows machine was available. An initial combined lint and snapshot command was denied by the session's permission check because it used a shell variable, so those checks were rerun as separate commands: repo-wide yarn lint and yarn format-check, and yarn verify-api-snapshots.

_{Automated review by Claude. Advisory only: it never approves or blocks, and a maintainer makes the call.}