fix: Remove FOLLY_NO_CONFIG flags from .pbxproj - #154
Closed
mrousavy wants to merge 1 commit into
Closed
Conversation
Since RN ships prebuilt binaries now, those flags are no longer needed in the `.pbxproj` file and can safely be removed (I just built NitroExample on RN 0.80 without those flags successfully) See react/react-native#52366 for more info
cortinico
approved these changes
Jul 15, 2025
cortinico
left a comment
cortinico
left a comment
Member
There was a problem hiding this comment.
Should be fine. Pinging @cipolleschi for a confirmation
Member
|
@mrousavy can you also open a pick request for this? |
Member
Author
|
Sorry wdym by pick request? |
Member
See here: https://github.com/reactwg/react-native-releases/#what-is-a-pick-request |
Member
Author
|
ok done: reactwg/react-native-releases#1038 |
Member
Author
|
Actually, I just built a blank new RN 0.80.1. again with my changes here and it fails to build because of some usage of glog. I have no idea how this can be related to Folly, but I think we still need those folly flags for now - maybe we should try migrating away from glog since that's deprecated anyways..? I'm closing this PR since we should probably keep the flags in the template for now, but we definitely have to remove them from the library template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Since RN ships prebuilt binaries now, those flags are no longer needed in the
.pbxprojfile and can safely be removed (I just built NitroExample on RN 0.80 without those flags successfully)See react/react-native#52366 for more info
Changelog:
[IOS] [FIXED] - Removed unused
FOLLY_NO_CONFIGfrom Xcode projectTest Plan:
Build an app without those flags and see if it works