Skip to content

MG 3.8.x compatibility and FSS Scale, Effect & RichTextLayout - #8

Merged
rds1983 merged 7 commits into
rds1983:masterfrom
GlitchyPSIX:master
Jun 20, 2026
Merged

MG 3.8.x compatibility and FSS Scale, Effect & RichTextLayout#8
rds1983 merged 7 commits into
rds1983:masterfrom
GlitchyPSIX:master

Conversation

@GlitchyPSIX

Copy link
Copy Markdown
Contributor

This PR updates the package to work with MG 3.8.x (.net 6 build instead of .net standard), and also adds the current FontStashSharp effect parameters

@rds1983

rds1983 commented Aug 17, 2024

Copy link
Copy Markdown
Owner

Sorry for the late response.
I've noticed that you've changed the formatting of the source code, which makes it hard to review the code.
Can I ask you to revert the formatting?

@GlitchyPSIX

Copy link
Copy Markdown
Contributor Author

Sorry for the late response. I've noticed that you've changed the formatting of the source code, which makes it hard to review the code. Can I ask you to revert the formatting?

Ah, this was a mistake. I will fix it in a moment.

@GlitchyPSIX GlitchyPSIX changed the title MG 3.8.x compatibility and FSS Scale & Effect MG 3.8.x compatibility and FSS Scale, Effect & RichTextLayout Aug 17, 2024
@GlitchyPSIX

GlitchyPSIX commented Aug 17, 2024

Copy link
Copy Markdown
Contributor Author

Hmm. It doesn't build. Is it using an older version of FSS? The latest version does have the Draw method with the scale parameter.

@orosbogdan

Copy link
Copy Markdown

@GlitchyPSIX any update on this?

@GlitchyPSIX

Copy link
Copy Markdown
Contributor Author

@GlitchyPSIX any update on this?

well this is embarrassing I absolutely forgot with everything that went on shortly after, let me recheck and get everything up to speed

@GlitchyPSIX

Copy link
Copy Markdown
Contributor Author

@rds1983 I have fixed what was requested and also added a .editorconfig to enforce your brace and tab style, I think this is good to review and merge

Builds are now working on my side on both agnostic building and MonoGame 3.8.1/FNA building

@rds1983

rds1983 commented Jun 19, 2026

Copy link
Copy Markdown
Owner

thanks for the PR,
but changing the indentation wasn't good idea. Since the it is hard to review.
Could you revert the old indentation? Also .editorconfig isn't needed.

@GlitchyPSIX

Copy link
Copy Markdown
Contributor Author

thanks for the PR, but changing the indentation wasn't good idea. Since the it is hard to review. Could you revert the old indentation? Also .editorconfig isn't needed.

@rds1983 Forgot to actually apply the identation reversal to the demo file. It has been done

@rds1983
rds1983 merged commit 1d7154a into rds1983:master Jun 20, 2026
1 check passed
@rds1983

rds1983 commented Jun 20, 2026

Copy link
Copy Markdown
Owner

thanks @GlitchyPSIX!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants