[FIX] Add error feedback and toast notification to CategoryFormModal - #286
Open
Siddh2024 wants to merge 1 commit into
Open
[FIX] Add error feedback and toast notification to CategoryFormModal#286Siddh2024 wants to merge 1 commit into
Siddh2024 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the admin “Add Category” modal UX by surfacing API failures to users (instead of only logging), and by confirming successful category creation via toast notification.
Changes:
- Added
submitErrorstate and an inline error banner withAlertCirclewhen category creation fails. - Added
toast.success()on successful category creation andtoast.error()on failure with the extracted API message. - Automatically clears the displayed error when the user edits any field.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }); | ||
|
|
||
| const [submitting, setSubmitting] = useState(false); | ||
| const [submitError, setSubmitError] = useState(""); |
Comment on lines
+85
to
+88
| <div className="flex items-start gap-3 p-4 bg-red-50 border border-red-200 rounded-xl"> | ||
| <AlertCircle className="w-5 h-5 text-red-500 shrink-0 mt-0.5" /> | ||
| <p className="text-sm text-red-700">{submitError}</p> | ||
| </div> |
Owner
|
Hi @Siddh2024 , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added user-facing error feedback to the category creation modal. Previously, API errors were silently swallowed with only a
console.errorcall.Changes Made
submitErrorstate variable to track API error messagesAlertCircleicon that appears on failuretoast.success()on successful category creationtoast.error()with the API error message on failureAlertCirclefrom lucide-react andtoastfrom react-hot-toastTesting
Fixes #283