Skip to content

[FIX] Add form validation to menu item creation modal #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Siddh2024 wants to merge 1 commit into
base: gssoc_develop
Choose a base branch
from
Open

[FIX] Add form validation to menu item creation modal #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions RestroHub-FrontEnd/src/components/admin/menu/menuCard/FoodItemFormModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,24 @@ const MenuFormModal = ({ isOpen, onClose, editingItem, allCategories }) => {
const description = formData.description.trim();
const imageUrl = formData.imageFile ? '' : formData.imageUrl.trim();

if (!name) nextErrors.name = 'Food item name is required.';
if (name && name.length < 2) nextErrors.name = 'Name must be at least 2 characters.';
if (name.length > 100) nextErrors.name = 'Name must be 100 characters or less.';
if (!name) {
nextErrors.name = 'Food item name is required.';
} else if (name.length < 2) {
nextErrors.name = 'Name must be at least 2 characters.';
} else if (name.length > 100) {
nextErrors.name = 'Name must be 100 characters or less.';
}

if (description.length > 500) nextErrors.description = 'Description must be 500 characters or less.';
if (!formData.price) nextErrors.price = 'Price is required.';
if (formData.price && (!Number.isFinite(price) || price <= 0)) nextErrors.price = 'Enter a valid price greater than 0.';
if (price > 9999.99) nextErrors.price = 'Price must be 9999.99 or less.';

if (!formData.price) {
nextErrors.price = 'Price is required.';
} else if (!Number.isFinite(price) || price <= 0) {
nextErrors.price = 'Enter a valid price greater than 0.';
} else if (price > 9999.99) {
nextErrors.price = 'Price must be 9999.99 or less.';
}

if (!formData.categoryId) nextErrors.categoryId = 'Select a category.';

if (imageUrl) {
Expand Down