Skip to content

Fix/tests idempotent no truncate metrics mt#128

Open
RahulRengeshOfficial wants to merge 198 commits into
mainfrom
fix/tests-idempotent-no-truncate-metrics-mt
Open

Fix/tests idempotent no truncate metrics mt#128
RahulRengeshOfficial wants to merge 198 commits into
mainfrom
fix/tests-idempotent-no-truncate-metrics-mt

Conversation

@RahulRengeshOfficial

Copy link
Copy Markdown

No description provided.

gravi21 and others added 30 commits July 16, 2025 19:41
Referring xconfwebconfig develop to xconfadmin develop and Resyncing
Referencing github path for xconfadmin
Fix build version and update go.mod to use latest version of xconfwebconfig
…d fix response for ip address group delete api
wakeuppool api creation changes
Refactor imports and enhance wakeup pool API
Refactor SAT Token Validation Logic
yeswanth2420 and others added 23 commits March 12, 2026 17:19
Improve MAC list reference validation error handling in firmware rules
…s and percentage beans

- baserule_validator.go: validate IP namespaced list existence when operation is IN_LIST and free arg is IP_ADDRESS/EstbIp
- baserule_validator.go: validate model existence when operation is IS and free arg is MODEL
- percentage_bean_service.go: introduce validatePercentageBeanReferences() to check model, whitelist IP list, and optional conditions
- percentage_bean_service.go: call validatePercentageBeanReferences() in both CreatePercentageBean and UpdatePercentageBean
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- baserule_validator_test.go: add tests for IN_LIST on IP_ADDRESS/EstbIp rejecting missing IP lists
- baserule_validator_test.go: add tests for IS on MODEL rejecting unknown models
- percentage_bean_service_test.go: add tests for validatePercentageBeanReferences covering invalid/valid model, missing/valid IP list, blank whitelist, and invalid optional conditions
- DB-write tests guarded with SkipIfMockDatabase for CI compatibility
…list-references

Add model and IP address list reference validation for rule conditions
…ential execution

- Add SkipIfMockDatabase() helper to skip tests that require real Cassandra
- Use unique IDs (timestamps) to prevent test collisions
- Add time.Sleep for Cassandra eventual consistency
- Update Makefile to run tests sequentially (-p 1) to avoid DB race conditions
- Tests now pass reliably in both mock and real DB modes
Fix flaky tests: add SkipIfMockDatabase pattern, unique IDs, and sequ…
- Adapt DAO calls to include tenantId parameter (multi-tenant API)
- Change xhome to rdkcloud (xhome invalid on multi-tenant)
- Use mock HTTP server for GroupServiceConnector tests
- Fix table name constants (singular to plural)
- Skip/fix tests with pre-existing multi-tenant failures
Copilot AI review requested due to automatic review settings May 21, 2026 15:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/xconfadmin/128/rdkcentral/xconfadmin

  • Commit: 847d90d

Report detail: gist'

- Add contrib/scripts/run_tests_with_summary.sh for JSON test logging and metrics
- Update Makefile test target to use the new script
- Ported from PR #124 (fix/tests-idempotent-no-truncate-metrics)
@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/xconfadmin/128/rdkcentral/xconfadmin

  • Commit: ee86fdf

Report detail: gist'

@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/xconfadmin/128/rdkcentral/xconfadmin

  • Commit: ee86fdf

Report detail: gist'

@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: OK

  • Commit: ee86fdf
    '

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.