RDKCOM-5598: RDKBDEV-3451, RDKBACCL-1834 Security mode shows WPAWPA2-PSK (TKIP/AES) on Web-UI upon changing to WPA3-Enterprise via dmcli#131
Open
ksaipr036 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WebUI security-mode display mapping so that when Device.WiFi.AccessPoint.*.Security.ModeEnabled is set to WPA3-Enterprise via DMCLI, the UI shows WPA3-Enterprise instead of falling back to the default WPAWPA2-PSK (TKIP/AES) label.
Changes:
- Add
WPA3-Enterprisehandling inencrypt_map()to return the correct display string.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Looks okay to me. But someone needs to review it once. |
Comment on lines
+1203
to
+1209
| }else if($WPA3_enable == "true" && $encrypt_mode == "WPA3-Enterprise"){ | ||
| ?> | ||
| <option value="WPA3-Personal Transition" <?% if ("WPA3-Personal Transition"==$security) echo( "selected");?> >WPA3-Personal Transition (Recommended)</option> | ||
| <option value="WPA3-Personal Only" <?% if ("WPA3-Personal Only"==$security) echo( "selected");?> >WPA3-Personal Only</option> | ||
| <option value="WPA3-Enterprise" <?% if ("WPA3-Enterprise"==$security) echo( "selected");?> >WPA3-Enterprise</option> | ||
| <option value="WPA2_PSK_AES" id="secmode4" title="WPA requires an 8-63 ASCII character password or a 64 hex character password. Hex means only the following characters can be used: ABCDEF0123456789." <?% if ("WPA2_PSK_AES"==$security) echo( "selected");?> >WPA2-PSK (AES)</option> | ||
| <?% |
ksaipr036
changed the title
pradeeptakdas
changed the title
…pon changing to WPA3-Enterprise via dmcli Reason for Change: Added WPA3-Enterprise in the encrypt_map() function to ensure the WebUI displays the correct security mode instead of the default(WPAWPA2-PSK) value. Test Procedure: Configure Device.WiFi.AccessPoint.*.Security.ModeEnabled to WPA3-Enterprise via DMCLI and verify the same from WebUI. Risks: Low. Signed-off-by: ksaipr036 <kosika_saipriya@comcast.com>
Comment on lines
+1176
to
+1180
| }else if($WPA3_enable == "true" && $encrypt_mode == "WPA3-Enterprise"){ | ||
| ?> | ||
| <option value="WPA3-Personal Only" id="secmode4" title="WPA requires an 8-63 ASCII character password or a 64 hex character password. Hex means only the following characters can be used: ABCDEF0123456789." <?% if ("WPA3-Personal Only"==$security) echo( "selected");?> >WPA3-Personal Only</option> | ||
| <option value="WPA3-Enterprise" <?% if ("WPA3-Enterprise"==$security) echo( "selected");?> >WPA3-Enterprise</option> | ||
| <?% |
Comment on lines
+1203
to
+1208
| }else if($WPA3_enable == "true" && $encrypt_mode == "WPA3-Enterprise"){ | ||
| ?> | ||
| <option value="WPA3-Personal Transition" <?% if ("WPA3-Personal Transition"==$security) echo( "selected");?> >WPA3-Personal Transition (Recommended)</option> | ||
| <option value="WPA3-Personal Only" <?% if ("WPA3-Personal Only"==$security) echo( "selected");?> >WPA3-Personal Only</option> | ||
| <option value="WPA3-Enterprise" <?% if ("WPA3-Enterprise"==$security) echo( "selected");?> >WPA3-Enterprise</option> | ||
| <option value="WPA2_PSK_AES" id="secmode4" title="WPA requires an 8-63 ASCII character password or a 64 hex character password. Hex means only the following characters can be used: ABCDEF0123456789." <?% if ("WPA2_PSK_AES"==$security) echo( "selected");?> >WPA2-PSK (AES)</option> |
Comment on lines
+1178
to
+1179
| <option value="WPA3-Personal Only" id="secmode4" title="WPA requires an 8-63 ASCII character password or a 64 hex character password. Hex means only the following characters can be used: ABCDEF0123456789." <?% if ("WPA3-Personal Only"==$security) echo( "selected");?> >WPA3-Personal Only</option> | ||
| <option value="WPA3-Enterprise" <?% if ("WPA3-Enterprise"==$security) echo( "selected");?> >WPA3-Enterprise</option> |
Comment on lines
+173
to
+175
| else if ("WPA3-Enterprise" == $encrypt_mode){ | ||
| $security = "WPA3-Enterprise"; | ||
| } |
|
@ksaipr036 please let us know once you have resolved all comments from copilot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: Added WPA3-Enterprise option in the encrypt_map() function to ensure the WebUI displays the correct security mode instead of the default(WPAWPA2-PSK) value.
Test Procedure: Configure Device.WiFi.AccessPoint.*.Security.ModeEnabled to WPA3-Enterprise via DMCLI and verify the same from WebUI for 2G, 5G and 6G.
Risks: Low.