Revert "fix(firewall): RDKB-64133: Restore #include <devicemode.h> and -ldevicemode inadvertently removed in PR #355"#362
Merged
GoutamD2905 merged 1 commit intoJul 3, 2026
Conversation
…d -ldevi…" This reverts commit f3f2bdb.
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts a prior firewall build change by removing the devicemode header/link dependency that had been (re-)added under the ONESTACK_PRODUCT_REQ conditional.
Changes:
- Drops
-ldevicemodefromsource/firewall/Makefile.amunderONESTACK_PRODUCT_REQ. - Removes
#include <devicemode.h>fromsource/firewall/firewall.cunder_ONESTACK_PRODUCT_REQ_.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/firewall/Makefile.am | Removes -ldevicemode linkage from the firewall build under ONESTACK_PRODUCT_REQ. |
| source/firewall/firewall.c | Removes the conditional devicemode.h include under _ONESTACK_PRODUCT_REQ_. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GoutamD2905
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #361