RDKBACCL-1853 SSH not working - Ethernet Configurable WAN Interface I…#351
Open
anatar818 wants to merge 10 commits into
Open
RDKBACCL-1853 SSH not working - Ethernet Configurable WAN Interface I…#351anatar818 wants to merge 10 commits into
anatar818 wants to merge 10 commits into
Conversation
…ntegration SSH not working - Ethernet Configurable WAN Interface Integration Modified the code to make it more generic and allow customised wan interface for the configurable wan feature
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the IPv4 firewall SSH (port 22) rule generation to support the “Ethernet Configurable WAN Interface” integration, so SSH filtering is applied on the appropriate WAN interface when the WAN interface name is customized at build-time.
Changes:
- Updates the ETH WAN SSH rule selection logic under
FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACEto prefer the active/current WAN interface instead of forcing the default interface. - Adds conditional compilation around the SSH interface-selection check to preserve legacy behavior when the feature flag is not enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12482
to
+12486
| #ifdef FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE | ||
| if (strcmp(current_wan_ifname, default_wan_ifname ) != 0) | ||
| #else | ||
| if (strcmp(current_wan_ifname, default_wan_ifname ) == 0) | ||
| #endif |
snayak002c
previously approved these changes
Jun 22, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
snayak002c
requested changes
Jul 1, 2026
Comment on lines
+2385
to
+2394
| #ifdef FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE | ||
| if ('\0' == current_wan_ifname[0]) { | ||
| char wanInterface[BUFLEN_64] = {'\0'}; | ||
| syscfg_get(NULL, "wan_physical_ifname", wanInterface, sizeof(wanInterface)); | ||
| if(wanInterface[0] != '\0') | ||
| snprintf(current_wan_ifname, sizeof(current_wan_ifname), "%s", wanInterface); | ||
| else | ||
| snprintf(current_wan_ifname, sizeof(current_wan_ifname), "%s", default_wan_ifname); | ||
| } | ||
| #else |
Comment on lines
+2386
to
+2393
| if ('\0' == current_wan_ifname[0]) { | ||
| char wanInterface[BUFLEN_64] = {'\0'}; | ||
| syscfg_get(NULL, "wan_physical_ifname", wanInterface, sizeof(wanInterface)); | ||
| if(wanInterface[0] != '\0') | ||
| snprintf(current_wan_ifname, sizeof(current_wan_ifname), "%s", wanInterface); | ||
| else | ||
| snprintf(current_wan_ifname, sizeof(current_wan_ifname), "%s", default_wan_ifname); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ntegration
SSH not working - Ethernet Configurable WAN Interface Integration Modified the code to make it more generic and allow customised wan interface for the configurable wan feature