Move mutex and message bus initialization into t2_init by yogeswaransky · Pull Request #387 · rdkcentral/telemetry

yogeswaransky · 2026-06-24T18:49:35Z

No description provided.

Copilot

Pull request overview

This PR moves mutex initialization and message bus initialization into t2_init(), so callers initialize shared synchronization primitives and the RBUS/CCSP bus handle upfront rather than during the first event send.

Changes:

Initialize all module mutexes in t2_init() via initMutex().
Attempt message bus initialization in t2_init() via initMessageBus(), logging and deferring retry to event send on failure.
Remove per-call initMutex() from t2_event_s().

 void t2_init(char *component)
 {
    componentName = strdup(component);
+    initMutex();
+
+    if(initMessageBus() != T2ERROR_SUCCESS)
+    {
+        EVENT_ERROR("%s:%d, T2:initMessageBus failed in t2_init, will retry during event send\n", __func__, __LINE__);
+    }
+    else
+    {
+        isRFCT2Enable = true;
+    }
 }


Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

…telemetry into feature/RDKEMW-19134

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.

 #define EVENT_ERROR(format, ...) \
-    fprintf(stderr, "T2ERROR:%s %s:%d: ", __func__ , __FILE__, __LINE__ ); \
+    fprintf(stderr, "T2INFO:%s %s:%d: ", __func__ , __FILE__, __LINE__ ); \
    fprintf(stderr, (format), ##__VA_ARGS__ ); \
    fprintf(stderr, "\n" );


 static T2ERROR initMessageBus( )
 {
-    // EVENT_DEBUG("%s ++in\n", __FUNCTION__);
+    EVENT_ERROR("%s ++in\n", __FUNCTION__);
    T2ERROR status = T2ERROR_SUCCESS;


+    EVENT_ERROR("%s --out\n", __FUNCTION__);
    return status;
 }


    EVENT_DEBUG("%s ++in\n", __FUNCTION__);
+    EVENT_ERROR("%s ++in\n", __FUNCTION__);
    if(!bus_handle)
    {


    EVENT_DEBUG("%s --out with status %d \n", __FUNCTION__, status);
+    EVENT_ERROR("%s --out with status %d \n", __FUNCTION__, status);
    return status;
 }


    snprintf(deNameSpace[0], 124, "%s%s%s", T2_ROOT_PARAMETER, componentName, T2_EVENT_LIST_PARAM_SUFFIX);
    EVENT_DEBUG("rbus mode : Query marker list with data element = %s \n", deNameSpace[0]);
+    EVENT_ERROR("rbus mode : Query marker list with data element = %s \n", deNameSpace[0]);

    pthread_mutex_lock(&markerListMutex);


        eventMarkerMap = hash_map_create();
        rbusProperty_t rbusPropertyList = rbusObject_GetProperties(objectValue);
        EVENT_DEBUG("\t rbus mode :  Update event map for component %s with below events : \n", componentName);
+        EVENT_ERROR("\t rbus mode :  Update event map for component %s with below events : \n", componentName);
        while(NULL != rbusPropertyList)
        {


    uint32_t t2ReadyStatus;
    rbusError_t retVal = RBUS_ERROR_SUCCESS;

    retVal = rbus_getUint(bus_handle, T2_OPERATIONAL_STATUS, &t2ReadyStatus);
+    EVENT_ERROR("Retrieved T2 Operational status: %d\n", t2ReadyStatus);

    if(retVal != RBUS_ERROR_SUCCESS)


    if(isT2Ready)
    {
-        // EVENT_DEBUG("T2: Sending event : %s\n", telemetry_data);
+        EVENT_ERROR("T2: Sending event : %s\n", telemetry_data);
        ret = filtered_event_send(telemetry_data, markerName);


 void t2_init(char *component)
 {
    componentName = strdup(component);
+    initMutex();
+
+    if(initMessageBus() != T2ERROR_SUCCESS)
+    {
+        EVENT_ERROR("%s:%d, T2:initMessageBus failed in t2_init, will retry during event send\n", __func__, __LINE__);
+    }
+    else
+    {
+        isRFCT2Enable = true;
+    }
 }


Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.

 #define EVENT_ERROR(format, ...) \
-    fprintf(stderr, "T2ERROR:%s %s:%d: ", __func__ , __FILE__, __LINE__ ); \
+    fprintf(stderr, "T2INFO:%s %s:%d: ", __func__ , __FILE__, __LINE__ ); \
    fprintf(stderr, (format), ##__VA_ARGS__ ); \
    fprintf(stderr, "\n" );


    uint32_t t2ReadyStatus;
    rbusError_t retVal = RBUS_ERROR_SUCCESS;

    retVal = rbus_getUint(bus_handle, T2_OPERATIONAL_STATUS, &t2ReadyStatus);
+    EVENT_ERROR("Retrieved T2 Operational status: %d\n", t2ReadyStatus);



+        EVENT_ERROR("T2: Sending event : %s\n", telemetry_data);
        ret = filtered_event_send(telemetry_data, markerName);


    EVENT_DEBUG("%s ++in\n", __FUNCTION__);
+    EVENT_ERROR("%s ++in\n", __FUNCTION__);
    if(!bus_handle)


    EVENT_DEBUG("%s --out with status %d \n", __FUNCTION__, status);
+    EVENT_ERROR("%s --out with status %d \n", __FUNCTION__, status);
    return status;
 }


 static T2ERROR initMessageBus( )
 {
-    // EVENT_DEBUG("%s ++in\n", __FUNCTION__);
+    EVENT_ERROR("%s ++in\n", __FUNCTION__);
    T2ERROR status = T2ERROR_SUCCESS;


    }
 #endif // CCSP_SUPPORT_ENABLED 
-    // EVENT_DEBUG("%s --out\n", __FUNCTION__);
+    EVENT_ERROR("%s --out\n", __FUNCTION__);
    return status;


 void t2_init(char *component)
 {
    componentName = strdup(component);
+    initMutex();
+
+    if(initMessageBus() != T2ERROR_SUCCESS)
+    {
+        EVENT_ERROR("%s:%d, T2:initMessageBus failed in t2_init, will retry during event send\n", __func__, __LINE__);
+    }
+    else
+    {
+        isRFCT2Enable = true;
+    }
 }


    snprintf(deNameSpace[0], 124, "%s%s%s", T2_ROOT_PARAMETER, componentName, T2_EVENT_LIST_PARAM_SUFFIX);
    EVENT_DEBUG("rbus mode : Query marker list with data element = %s \n", deNameSpace[0]);
+    EVENT_ERROR("rbus mode : Query marker list with data element = %s \n", deNameSpace[0]);



        rbusProperty_t rbusPropertyList = rbusObject_GetProperties(objectValue);
        EVENT_DEBUG("\t rbus mode :  Update event map for component %s with below events : \n", componentName);
+        EVENT_ERROR("\t rbus mode :  Update event map for component %s with below events : \n", componentName);
        while(NULL != rbusPropertyList)


Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

Comments suppressed due to low confidence (1)

source/commonlib/telemetry_busmessage_sender.c:449

When bus_handle is NULL this function currently returns ret (RBUS_ERROR_SUCCESS), which makes the caller think the send succeeded. Return a failure status consistently for the int return type.

    if(!bus_handle)
    {
        EVENT_ERROR("bus_handle is null .. exiting !!! \n");
        return ret;
    }

+    if(pthread_create(&initThread, NULL, t2_init_worker, NULL) != 0)
+    {
+        EVENT_ERROR("%s:%d, T2:Failed to create init worker thread, falling back to sync init\n", __func__, __LINE__);
+        t2_init_worker(NULL);
+    }


+        isRFCT2Enable = true;
+    }
+
+    isT2InitComplete = true;


    uint32_t t2ReadyStatus;
    rbusError_t retVal = RBUS_ERROR_SUCCESS;

    retVal = rbus_getUint(bus_handle, T2_OPERATIONAL_STATUS, &t2ReadyStatus);
+    EVENT_ERROR("Retrieved T2 Operational status: %d\n", t2ReadyStatus);


    if(isT2Ready)
    {
-        // EVENT_DEBUG("T2: Sending event : %s\n", telemetry_data);
+        EVENT_ERROR("T2: Sending event : %s\n", telemetry_data);
        ret = filtered_event_send(telemetry_data, markerName);


 #define EVENT_ERROR(format, ...) \
-    fprintf(stderr, "T2ERROR:%s %s:%d: ", __func__ , __FILE__, __LINE__ ); \
+    fprintf(stderr, "T2INFO:%s %s:%d: ", __func__ , __FILE__, __LINE__ ); \
    fprintf(stderr, (format), ##__VA_ARGS__ ); \
    fprintf(stderr, "\n" );


+    if(!isT2InitComplete)
+    {
+        EVENT_DEBUG("%s:%d, T2:t2_init is not complete, dropping event %s\n", __func__, __LINE__, marker ? marker : "NULL");
+        return T2ERROR_FAILURE;
+    }
    if(componentName == NULL)
    {
        EVENT_DEBUG("%s:%d, T2:component with pid = %d is trying to send event %s with value %s without component name \n", __func__, __LINE__, (int) getpid(), marker, value);
        return T2ERROR_COMPONENT_NULL;
    }


+    if(!isT2InitComplete)
+    {
+        EVENT_DEBUG("%s:%d, T2:t2_init is not complete, dropping event %s\n", __func__, __LINE__, marker ? marker : "NULL");
+        return T2ERROR_FAILURE;
+    }


+    if(!isT2InitComplete)
+    {
+        EVENT_DEBUG("%s:%d, T2:t2_init is not complete, dropping event %s\n", __func__, __LINE__, marker ? marker : "NULL");
+        return T2ERROR_FAILURE;
+    }


    componentName = strdup(component);
+
+    if(pthread_create(&initThread, NULL, t2_init_worker, NULL) != 0)
+    {


Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Move mutex and message bus initialization into t2_init

b19c78a

Copilot AI review requested due to automatic review settings June 24, 2026 18:49

yogeswaransky requested a review from a team as a code owner June 24, 2026 18:49

Copilot started reviewing on behalf of yogeswaransky June 24, 2026 18:49 View session

Copilot AI reviewed Jun 24, 2026

View reviewed changes

yogeswaransky added 2 commits June 26, 2026 07:59

RDKEMW-19134: Move mutex and message bus initialization into t2_init

abbe305

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

RDKB-65318: Enhancements

8601cdc

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot AI review requested due to automatic review settings June 26, 2026 10:34

Copilot started reviewing on behalf of yogeswaransky June 26, 2026 10:35 View session

yogeswaransky added 2 commits June 26, 2026 10:35

RDKEMW-19134: Move mutex and message bus initialization into t2_init

4ded52c

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Merge branch 'feature/RDKEMW-19134' of https://github.com/rdkcentral/…

4064a86

…telemetry into feature/RDKEMW-19134

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 26, 2026 10:38

Copilot started reviewing on behalf of yogeswaransky June 26, 2026 10:38 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

yogeswaransky added 2 commits July 5, 2026 14:58

RDKEMW-19134: Synchronizing t2_init with t2_event calls

76a633f

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

RDKEMW-19134: Synchronizing t2_init with t2_event calls

b08e01d

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot AI review requested due to automatic review settings July 6, 2026 09:52

Copilot started reviewing on behalf of yogeswaransky July 6, 2026 09:53 View session

Copilot AI reviewed Jul 6, 2026

View reviewed changes

RDKEMW-19134: Synchronizing t2_init with t2_event calls

49d8308

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move mutex and message bus initialization into t2_init#387

Move mutex and message bus initialization into t2_init#387
yogeswaransky wants to merge 8 commits into
support/1.9from
feature/RDKEMW-19134

yogeswaransky commented Jun 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		EVENT_ERROR("T2: Sending event : %s\n", telemetry_data);
		ret = filtered_event_send(telemetry_data, markerName);

Uh oh!

Conversation

yogeswaransky commented Jun 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants