RDKEMW-21013: Add boot-time timeout for DeviceInfo MAC cache in SystemServices Configure#564
Open
nanimatta wants to merge 3 commits into
Open
RDKEMW-21013: Add boot-time timeout for DeviceInfo MAC cache in SystemServices Configure#564nanimatta wants to merge 3 commits into
nanimatta wants to merge 3 commits into
Conversation
…mServices Configure
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a small execution-time guard to prevent slow/hung device-info commands from blocking boot-time device detail collection, by introducing a timeout wrapper and applying it to MAC/manufacturer lookups.
Changes:
- Introduced
run_with_timeout()with a fixedDETAILS_CMD_TIMEOUTto wrap commands whentimeoutis available. - Wrapped
ifconfigMAC-address extraction calls with the timeout helper. - Wrapped
mfr_util --Manufacturercalls with the timeout helper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+35
to
+38
| GDD_TRACE=${GDD_TRACE:-1} | ||
| trace_gdd() { | ||
| [ "$GDD_TRACE" = "1" ] && echo "GDD_TRACE: ts=$(date +%s) pid=$$ cmd=$command param=$parameter $*" >> /tmp/gdd_trace.log | ||
| } |
Comment on lines
+415
to
+417
| trace_gdd "estb_mac_start" | ||
| MacAddress=`getEstbMacAddress` | ||
| trace_gdd "estb_mac_done rc=$?" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.