RDKEMW-18434 : [BCM Rogers Monarch IUI V2] RialtoServer process crash observed while switching between Xumo FAST channels during CC verification by rekhap2kandhavelan · Pull Request #554 · rdkcentral/rialto

rekhap2kandhavelan · 2026-07-03T03:31:54Z

Summary: handling race conditions for GstPlayer
Type: Fix
Test Plan: UT/CT, Fullstac
Jira: RDKEMW-18434

github-actions · 2026-07-03T03:32:05Z

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

Copilot

Pull request overview

This PR aims to prevent RialtoServer crashes seen during FAST channel switching by hardening MediaPipelineServerInternal against race conditions involving GstGenericPlayer teardown and late/overlapping callbacks.

Changes:

Reset m_gstPlayer during MediaPipelineServerInternal destruction.
Gate notifyPlaybackInfo() forwarding on m_gstPlayer validity and add a warning when skipped.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-07-03T03:42:41Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.3%
Functions coverage stays unchanged and is: 92.7%

svc-rdkeportal01 · 2026-07-03T04:09:43Z

CCI-Build-Verified -1
sha: d822db8

github-actions · 2026-07-03T07:19:55Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.3%
Functions coverage stays unchanged and is: 92.7%

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

github-actions · 2026-07-03T09:43:50Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.3%
Functions coverage stays unchanged and is: 92.7%

resolve valgrind l1

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

github-actions · 2026-07-03T10:48:38Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.3%
Functions coverage stays unchanged and is: 92.7%

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Update MediaPipelineServerInternal.cpp

d822db8

Copilot AI review requested due to automatic review settings July 3, 2026 03:31

Copilot started reviewing on behalf of rekhap2kandhavelan July 3, 2026 03:32 View session

Copilot AI reviewed Jul 3, 2026

View reviewed changes

Comment thread media/server/main/source/MediaPipelineServerInternal.cpp Outdated

Comment thread media/server/main/source/MediaPipelineServerInternal.cpp Outdated

Comment thread media/server/main/source/MediaPipelineServerInternal.cpp Outdated

rekhap2kandhavelan force-pushed the feature/RDKEMW-18434_dev branch from 15ed5e5 to 73254e2 Compare July 3, 2026 09:33

Copilot AI review requested due to automatic review settings July 3, 2026 09:33

Copilot started reviewing on behalf of rekhap2kandhavelan July 3, 2026 09:33 View session

Copilot AI reviewed Jul 3, 2026

View reviewed changes

Comment thread media/server/gstplayer/source/GstGenericPlayer.cpp Outdated

rekhap2kandhavelan force-pushed the feature/RDKEMW-18434_dev branch from 73254e2 to 0382aee Compare July 3, 2026 10:05

Update MediaPipelineServerInternal.cpp

e660c09

resolve valgrind l1

rekhap2kandhavelan force-pushed the feature/RDKEMW-18434_dev branch from 0382aee to e660c09 Compare July 3, 2026 10:36

Copilot AI review requested due to automatic review settings July 3, 2026 10:36

Copilot started reviewing on behalf of rekhap2kandhavelan July 3, 2026 10:37 View session

Copilot AI reviewed Jul 3, 2026

View reviewed changes

Comment thread media/server/gstplayer/source/GstGenericPlayer.cpp Outdated

Potential fix for pull request finding

f422cd0

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 4, 2026 14:21

Copilot started reviewing on behalf of rekhap2kandhavelan July 4, 2026 14:21 View session

Copilot AI reviewed Jul 4, 2026

View reviewed changes

Comment thread media/server/gstplayer/source/GstGenericPlayer.cpp Outdated

Potential fix for pull request finding

b552061

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 4, 2026 14:30

Copilot started reviewing on behalf of rekhap2kandhavelan July 4, 2026 14:31 View session

Copilot AI reviewed Jul 4, 2026

View reviewed changes

Update GstGenericPlayer.cpp

dc66d0c

Uh oh!

Conversation

rekhap2kandhavelan commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

svc-rdkeportal01 commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants