RDKEMW-17667 : Add timezone getter method and onTimeZoneChanged event#83
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds timezone support to the Firebolt Localization module by introducing a new read-only timeZone getter and a corresponding onTimeZoneChanged subscription event, with implementation and OpenRPC/test coverage updates to keep the API surface consistent across the SDK.
Changes:
- Added
ILocalization::timeZone()getter andILocalization::subscribeOnTimeZoneChanged(...)event subscription API. - Implemented the new getter and subscription in
LocalizationImpl. - Updated unit/component tests and OpenRPC specs to cover the new method/event and validate payload handling.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/localizationTest.cpp | Adds unit tests for timeZone() success/failure and subscribing to onTimeZoneChanged. |
| test/component/localizationTest.cpp | Adds component tests for timeZone() and validates event delivery vs. invalid payloads. |
| src/localization_impl.h | Extends LocalizationImpl interface with timeZone() and subscribeOnTimeZoneChanged(...). |
| src/localization_impl.cpp | Implements timeZone() getter and onTimeZoneChanged subscription wiring. |
| include/firebolt/localization.h | Extends public ILocalization API with the new getter and subscription method + docs. |
| docs/openrpc/the-spec/firebolt-open-rpc.json | Adds OpenRPC entries for Localization.timeZone and Localization.onTimeZoneChanged. |
| docs/openrpc/openrpc/localization.json | Adds module-level OpenRPC entry for timeZone. |
swethasukumarr
force-pushed
the
feature/RDKEMW-17667
branch
from
acf4841 to
55023c7
Compare
satlead
approved these changes
Jun 29, 2026
swethasukumarr
force-pushed
the
feature/RDKEMW-17667
branch
from
5941f5a to
7793784
Compare
Rajanika
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.