Add ratelimit L2 Test cases and update Spec#68
Open
gomathishankar37 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds/updates the L2 functional test specification and supporting documentation around rate-limiting semantics, and extends unit test coverage to validate that the deny-window cooldown is global (affecting coredumps too).
Changes:
- Add a new GTest covering coredump behavior when the global deny-window is active.
- Introduce a comprehensive
uploadDumps.shfunctional test-case specification document and update L2 tracking matrices to reflect clarified rate-limit semantics. - Update OpenSpec/runtime docs and README links to reflect the global deny-window vs minidump-only counter behavior.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| unittest/ratelimit_gtest.cpp | Adds a unit test asserting coredumps are blocked while the global deny-window is active. |
| test/uploadDumps_TestCases.md | New, large functional test-case spec for uploadDumps.sh, including rate-limit scenarios. |
| test/L2_TODO.md | Updates TC-050 wording to clarify minidump-only counter check. |
| test/L2_TESTS.md | Updates applicability/notes to reflect global deny-window gating and minidump-only counter logic. |
| test/functional-tests/tests/test_ratelimit_allow.py | Updates test documentation/comments to align with clarified semantics. |
| test/functional-tests/tests/README.md | Fixes relative links to the test-case spec and L2 matrix under test/. |
| test/functional-tests/features/ratelimit.feature | Updates descriptive Gherkin text for TC-050 to include deny-window precondition. |
| README.md | Updates L2 coverage reference to point at test/L2_TESTS.md. |
| openspec/subsystems/subsystem-analysis.md | Documents deny-window as a global cooldown and the minidump timestamp file as minidump-only. |
| openspec/runtime/execution-model.md | Clarifies ordering/semantics of deny-window vs dump-type-specific checks. |
| openspec/integrations/client-integration-model.md | Adds a concise “Rate-Limit State Semantics” section. |
| openspec/config.yaml | Updates referenced L2 matrix path to test/L2_TESTS.md. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.