RDKEMW-14533: Coverity inclusion - fork code check#76
Closed
PreethiALPI wants to merge 1 commit into
Closed
Conversation
Reason for change: Inclusion of coverity for BT Test Procedure: check action's workflow logs if succeeded Risks: Low Priority: P2 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a GitHub Actions workflow and supporting shell scripts to build BT-Core in a native (containerized) CI environment, intended to support Coverity integration / fork build checks.
Changes:
- Added
build_dependencies.shto install build prerequisites and stage external headers/libs (telemetry + legacy BlueZ headers). - Added
cov_build.shto bootstrap autotools, configure, and build the component. - Added
.github/workflows/native_full_build.ymlto run the dependency setup and build in CI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
cov_build.sh |
Adds an autotools bootstrap + configure + build script for CI/Coverity builds. |
build_dependencies.sh |
Installs packages, clones upstream deps, and creates stub telemetry + legacy BlueZ headers. |
.github/workflows/native_full_build.yml |
Introduces a container-based GitHub Actions workflow to run the scripts on PRs/pushes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+12
| libtoolize --force | ||
| aclocal | ||
| autoheader | ||
| automake --force-missing --add-missing | ||
| autoconf |
| export CXXFLAGS="-Wno-error" | ||
| export LD_LIBRARY_PATH="${WORKSPACE}/external/lib" | ||
|
|
||
| ac_cv_header_telemetry_busmessage_sender_h=yes ./configure |
Comment on lines
+26
to
+27
| make -C src/bt-ifce -j$(nproc) | ||
| make -C src -j$(nproc) |
Comment on lines
+25
to
+30
| cat << 'EOF' > telemetry_stub.c | ||
| int t2_init(void) { return 0; } | ||
| int t2_event_s(const char* n, const char* v) { return 0; } | ||
| int t2_event_f(const char* n, float v) { return 0; } | ||
| int t2_event_d(const char* n, double v) { return 0; } | ||
| EOF |
|
|
||
| echo "Setting up telemetry stub..." | ||
|
|
||
| git clone https://github.com/rdkcentral/telemetry.git |
|
|
||
| echo "Setting up BlueZ legacy headers..." | ||
|
|
||
| git clone https://github.com/bluez/bluez.git |
Comment on lines
+19
to
+23
| mkdir -p ${WORKSPACE}/external/include | ||
| mkdir -p ${WORKSPACE}/external/lib | ||
|
|
||
| cp telemetry/include/telemetry_busmessage_sender.h ${WORKSPACE}/external/include/ | ||
| cp telemetry/include/telemetry2_0.h ${WORKSPACE}/external/include/ |
Comment on lines
+55
to
+56
| sed -i '1i#include <stdbool.h>\n' \ | ||
| ${WORKSPACE}/external/include/bluetooth/audio/ipc.h |
| # Checkout | ||
| # ---------------------------------------- | ||
| - name: Checkout source | ||
| uses: actions/checkout@v6 |
| native-build: | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: ghcr.io/rdkcentral/docker-rdk-ci:latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Inclusion of coverity for BT
Test Procedure: check action's workflow logs if succeeded
Risks: Low
Priority: P2