RDKEMW-14533: Coverity inclusion changes for core#74
Closed
PreethiALPI wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a native (Ubuntu) build workflow plus helper scripts intended to support Coverity enablement by bootstrapping autotools, installing dependencies, and building BT-Core in CI.
Changes:
- Added
build_dependencies.shto install system packages and stage external telemetry/BlueZ headers + a telemetry stub library. - Added
cov_build.shto bootstrap autotools, configure, and build the project. - Added GitHub Actions workflow to run dependency setup + native build on
developpushes/PRs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
cov_build.sh |
New build script to bootstrap autotools, configure, and compile the project in a Coverity-friendly way. |
build_dependencies.sh |
New dependency/setup script that installs packages and stages external headers/libs required for a native build. |
.github/workflows/native_full_build.yml |
New CI workflow to run the above scripts on develop pushes and PRs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| echo "Setting up telemetry stub..." | ||
|
|
||
| git clone https://github.com/rdkcentral/telemetry.git |
Comment on lines
+19
to
+23
| mkdir -p ${WORKSPACE}/external/include | ||
| mkdir -p ${WORKSPACE}/external/lib | ||
|
|
||
| cp telemetry/include/telemetry_busmessage_sender.h ${WORKSPACE}/external/include/ | ||
| cp telemetry/include/telemetry2_0.h ${WORKSPACE}/external/include/ |
Comment on lines
+55
to
+56
| sed -i '1i#include <stdbool.h>\n' \ | ||
| ${WORKSPACE}/external/include/bluetooth/audio/ipc.h |
| export CXXFLAGS="-Wno-error" | ||
| export LD_LIBRARY_PATH="${WORKSPACE}/external/lib" | ||
|
|
||
| ac_cv_header_telemetry_busmessage_sender_h=yes ./configure |
| export LDFLAGS="-L${WORKSPACE}/external/lib" | ||
| export CFLAGS="-Wno-error" | ||
| export CXXFLAGS="-Wno-error" | ||
| export LD_LIBRARY_PATH="${WORKSPACE}/external/lib" |
PreethiALPI
force-pushed
the
RDKEMW-14533_new_core
branch
from
3f0fed9 to
ecce02e
Compare
PreethiALPI
force-pushed
the
RDKEMW-14533_new_core
branch
from
ecce02e to
7979a9c
Compare
PreethiALPI
force-pushed
the
RDKEMW-14533_new_core
branch
from
7979a9c to
fce57cb
Compare
Comment on lines
+21
to
+23
|
|
||
| ac_cv_header_telemetry_busmessage_sender_h=yes ./configure | ||
|
|
Comment on lines
+25
to
+34
| cat << 'EOF' > telemetry_stub.c | ||
| int t2_init(void) { return 0; } | ||
| int t2_event_s(const char* n, const char* v) { return 0; } | ||
| int t2_event_f(const char* n, float v) { return 0; } | ||
| int t2_event_d(const char* n, double v) { return 0; } | ||
| EOF | ||
|
|
||
| gcc -shared -fPIC telemetry_stub.c \ | ||
| -o ${WORKSPACE}/external/lib/libtelemetry_msgsender.so | ||
|
|
Comment on lines
+15
to
+18
| echo "Setting up telemetry stub..." | ||
|
|
||
| git clone https://github.com/rdkcentral/telemetry.git | ||
|
|
PreethiALPI
force-pushed
the
RDKEMW-14533_new_core
branch
from
fce57cb to
9b74269
Compare
PreethiALPI
changed the title
PreethiALPI
force-pushed
the
RDKEMW-14533_new_core
branch
from
9b74269 to
283a642
Compare
Comment on lines
+4
to
+11
| echo "Installing system dependencies..." | ||
|
|
||
| sudo apt-get update | ||
| sudo apt-get install -y \ | ||
| autoconf automake libtool pkg-config \ | ||
| gcc g++ make \ | ||
| libglib2.0-dev libdbus-1-dev libbluetooth-dev \ | ||
| git |
|
|
||
| echo "Setting up telemetry stub..." | ||
|
|
||
| git clone https://github.com/rdkcentral/telemetry.git |
|
|
||
| echo "Setting up BlueZ legacy headers..." | ||
|
|
||
| git clone https://github.com/bluez/bluez.git |
Comment on lines
+16
to
+20
| export CPPFLAGS="-I${WORKSPACE}/external/include" | ||
| export LDFLAGS="-L${WORKSPACE}/external/lib" | ||
| export CFLAGS="-Wno-error" | ||
| export CXXFLAGS="-Wno-error" | ||
| export LD_LIBRARY_PATH="${WORKSPACE}/external/lib" |
PreethiALPI
force-pushed
the
RDKEMW-14533_new_core
branch
from
283a642 to
55b4914
Compare
Reason for change: Inclusion of coverity for BT Test Procedure: check action's workflow logs if succeeded Risks: Low Priority: P2 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
PreethiALPI
force-pushed
the
RDKEMW-14533_new_core
branch
from
55b4914 to
6455e01
Compare
Comment on lines
+13
to
+14
| container: | ||
| image: ghcr.io/rdkcentral/docker-rdk-ci:latest |
Comment on lines
+16
to
+20
| export CPPFLAGS="-I${WORKSPACE}/external/include" | ||
| export LDFLAGS="-L${WORKSPACE}/external/lib" | ||
| export CFLAGS="-Wno-error" | ||
| export CXXFLAGS="-Wno-error" | ||
| export LD_LIBRARY_PATH="${WORKSPACE}/external/lib" |
| export CXXFLAGS="-Wno-error" | ||
| export LD_LIBRARY_PATH="${WORKSPACE}/external/lib" | ||
|
|
||
| ac_cv_header_telemetry_busmessage_sender_h=yes ./configure |
|
|
||
| echo "Setting up telemetry stub..." | ||
|
|
||
| git clone https://github.com/rdkcentral/telemetry.git |
Comment on lines
+25
to
+30
| cat << 'EOF' > telemetry_stub.c | ||
| int t2_init(void) { return 0; } | ||
| int t2_event_s(const char* n, const char* v) { return 0; } | ||
| int t2_event_f(const char* n, float v) { return 0; } | ||
| int t2_event_d(const char* n, double v) { return 0; } | ||
| EOF |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Inclusion of coverity for BT
Test Procedure: NA
Risks: Low
Priority: P2