VPAAMP-470: [Timeshift DAI] Confirm TimedMetadata is reported in Hot/Cold CDVR/iVOD cases#1682
Open
srikanthreddybijjam-comcast wants to merge 1 commit into
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Vinish100
reviewed
Jul 3, 2026
| timeShiftBufferDepth="PT3H" | ||
| suggestedPresentationDelay="PT10S"> | ||
| <!-- Period-1: 10:00 – 10:30, main video, no EventStream --> | ||
| <Period id="Period-1" start="PT0S" duration="PT1800S"> |
Contributor
There was a problem hiding this comment.
Skip duration. Periods will be always in a single format. Either has period duration or not
| if (periodStartMS < valueMS) | ||
| periodStartMS = valueMS; | ||
| } | ||
| else if (periodCnt > 1 && mMPDParseHelper && mMPDParseHelper->IsEmptyPeriod(periodCnt-1, (mPlayRate != AAMP_NORMAL_PLAY_RATE))) |
Contributor
There was a problem hiding this comment.
add a check for only last period. Lets make it only EAP specific logic
Add some comments on periodCnt-1, periodCnt-2 and all.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds coverage and logic to correctly compute timed-metadata start times for “Early Available Period” (EAP) / empty-period scenarios in dynamic MPDs, ensuring TimedMetadata is reported with the expected period-relative start across hot/cold CDVR and iVOD cases (VPAAMP-470).
Changes:
- Added a new unit test MPD scenario validating calculated
periodStartMSwhen an EAP Period has no@start/@duration. - Extended MPD parse-helper test mocking to support
IsEmptyPeriod(...). - Updated
StreamAbstractionAAMP_MPD::FindTimedMetadatato adjust period start time when encountering an empty (EAP) Period without@start.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/utests/tests/fragmentcollector_mpd/FindTimedMetadataTests.cpp | Adds new EAP/EventStream unit test and wires MPD parse-helper mocking into the test fixture. |
| test/utests/mocks/MockAampMPDParseHelper.h | Extends mock interface with IsEmptyPeriod(...). |
| test/utests/fakes/FakeAampMPDParseHelper.cpp | Routes IsEmptyPeriod(...) calls through the global mock when present. |
| fragmentcollector_mpd.cpp | Adjusts periodStartMS calculation for empty/EAP Periods without @start. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5026
to
+5030
| else if (periodCnt > 1 && mMPDParseHelper && mMPDParseHelper->IsEmptyPeriod(periodCnt-1, (mPlayRate != AAMP_NORMAL_PLAY_RATE))) | ||
| { | ||
| periodStartMS += mMPDParseHelper->GetPeriodDuration(periodCnt-2, mLastPlaylistDownloadTimeMs, (mPlayRate != AAMP_NORMAL_PLAY_RATE), aamp->IsUninterruptedTSB()); | ||
| AAMPLOG_WARN("Empty period found, id=%s periodStartMS adjusted to %" PRIu64 " ms", node->GetAttributeValue("id").c_str(), periodStartMS); | ||
| } |
srikanthreddybijjam-comcast
force-pushed
the
feature/VPAAMP-470_TIMEDMETADATA_NEW
branch
5 times, most recently
from
46be7a2 to
a6cf531
Compare
…ream Reason for change:Added a EAP check and used the starttime of the periods Test Procedure: Refer jira ticket VPAAMP-470 Priority: P2 Signed-off-by: srikanthreddybijjam-comcast <srikanthreddybijjam.2000@gmail.com>
srikanthreddybijjam-comcast
force-pushed
the
feature/VPAAMP-470_TIMEDMETADATA_NEW
branch
from
a6cf531 to
7feac1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added a EAP check and calculated start time accordingly
Test Procedure: Refer jira ticket VPAAMP-470
Priority: P2