Add property coverage to @uncompliant tests#294
Draft
smanes0213 wants to merge 7 commits into
Draft
Conversation
Both @uncompliant:extended and @uncompliant:collapsed are deprecated (Thunder docs/plugin/interfaces/tags.md) and tested here solely to pin existing generator behaviour against regressions Both test interfaces previously only contained a single echo method — for @uncompliant:extended this meant the test exercised zero distinguishing behaviour: the mode's only effect is on property parameter encoding, not methods, making the test identical to @compliant Added a Value read/write @Property to both interfaces so the tests actually expose what each mode does differently: @uncompliant:extended: property SET sends a bare scalar (42 not {"value":42}); methods remain wrapped — only properties are affected @uncompliant:collapsed: property SET and single-param methods both send bare scalars; collapsed tests additionally assert that sending a wrapped object to a collapsed method is rejected Signed-off-by: smanes0213 <sankalpmaneshwar46@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: The Branch addition in ProxyStubFunctionalTest.yml is temporary to run the tests on current branch.