RDKB-65853 Fixing coverity issue#1248
Open
sshah500 wants to merge 2 commits into
Open
Conversation
Reason for change: Fixing coverity issues. Test Procedure: Build should be successful and the regression test should also succeed Risks: Low Priority: P1 Signed-off-by: Sachinkumar_shah@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Coverity findings by cleaning up resources that were previously left allocated/open after specific translation and connection-handling code paths.
Changes:
- Free decoded assoc-device stats buffers after translating them into EasyMesh STA info.
- Free decoded EasyMesh STA link metrics array after translation.
- Free decoded channel-scan stats buffer (including on early error when the external proto is missing).
- Close a client socket FD when removing a disconnected unicast client from the connection map.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/webconfig/wifi_easymesh_translator.c | Adds explicit frees/nulling for decoded stats buffers after translation to prevent leaks. |
| source/platform/linux/he_bus/src/he_bus_connection.c | Closes a removed client’s socket FD before freeing its connection-info structure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed
Risks: Low
Priority: P1
Signed-off-by: Sachinkumar_shah@comcast.com