Skip to content

RDKB-65853: Fixing coverity issue#1247

Open
navyasher wants to merge 1 commit into
rdkcentral:developfrom
navyasher:Manish_cov
Open

RDKB-65853: Fixing coverity issue#1247
navyasher wants to merge 1 commit into
rdkcentral:developfrom
navyasher:Manish_cov

Conversation

@navyasher

Copy link
Copy Markdown
Contributor

Reason for change: Fixing coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed
Risks: Low
Priority: P1
Signed-off-by: Navya_Sheregar@comcast.com

Reason for change: Fixing coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed
Risks: Low
Priority: P1
Signed-off-by: Navya_Sheregar@comcast.com
Copilot AI review requested due to automatic review settings July 6, 2026 13:53
@navyasher navyasher requested a review from a team as a code owner July 6, 2026 13:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Coverity-reported resource leaks by ensuring webconfig_subdoc_data_t encoded buffers are freed on all exit paths, and removes an unused union member from a monitoring payload struct.

Changes:

  • Added webconfig_data_free() calls before freeing webconfig_subdoc_data_t in multiple error and success paths to prevent leaks of u.encoded.raw.
  • Fixed a leak in EasyMesh disassociation handling by freeing the removed hash-map value (stats).
  • Removed an unused associated_devs_t devs union member from wifi_monitor_data_t.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
source/apps/linkquality/wifi_linkquality.c Ensures webconfig_subdoc_data_t encoded raw buffer is freed on encode/publish failures and after success.
source/apps/em/wifi_em.c Adds missing webconfig_data_free() cleanup in several publish paths and frees removed client stats on disassoc.
include/wifi_base.h Removes unused devs union member from wifi_monitor_data_t.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants