RDKB-65853: Fixing coverity issue#1247
Open
navyasher wants to merge 1 commit into
Open
Conversation
Reason for change: Fixing coverity issues. Test Procedure: Build should be successful and the regression test should also succeed Risks: Low Priority: P1 Signed-off-by: Navya_Sheregar@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Coverity-reported resource leaks by ensuring webconfig_subdoc_data_t encoded buffers are freed on all exit paths, and removes an unused union member from a monitoring payload struct.
Changes:
- Added
webconfig_data_free()calls before freeingwebconfig_subdoc_data_tin multiple error and success paths to prevent leaks ofu.encoded.raw. - Fixed a leak in EasyMesh disassociation handling by freeing the removed hash-map value (
stats). - Removed an unused
associated_devs_t devsunion member fromwifi_monitor_data_t.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/apps/linkquality/wifi_linkquality.c | Ensures webconfig_subdoc_data_t encoded raw buffer is freed on encode/publish failures and after success. |
| source/apps/em/wifi_em.c | Adds missing webconfig_data_free() cleanup in several publish paths and frees removed client stats on disassoc. |
| include/wifi_base.h | Removes unused devs union member from wifi_monitor_data_t. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed
Risks: Low
Priority: P1
Signed-off-by: Navya_Sheregar@comcast.com