Skip to content

RDKBWIFI-494: Prevent TransitionDisable configuration in unsupported …#1246

Open
shaheeda-cg wants to merge 1 commit into
rdkcentral:developfrom
shaheeda-cg:fix_wpa3_transition_disable_issue
Open

RDKBWIFI-494: Prevent TransitionDisable configuration in unsupported …#1246
shaheeda-cg wants to merge 1 commit into
rdkcentral:developfrom
shaheeda-cg:fix_wpa3_transition_disable_issue

Conversation

@shaheeda-cg

Copy link
Copy Markdown

RDKBWIFI-494 Transition Disable parameter accepts SET operations in security modes other than WPA3-Personal-Transition

  • Added security mode validation before updating TransitionDisable parameter
  • Restricted TransitionDisable SET operation to WPA3-Personal-Transition mode only
  • Added error logging for invalid SET requests in unsupported security modes
  • Prevented configuration updates when the current security mode does not support TransitionDisable

This ensures TransitionDisable parameter is accepted only for WPA3-Personal-Transition security mode, aligning behavior with expected functionality and preventing invalid configuration changes.
Signed-off-by:
Shaik, Shaheeda shaheeda.shaik@capgemini.com
Sangram Babar, Snehal snehal.sangram-babar@capgemini.com

Copilot AI review requested due to automatic review settings July 3, 2026 12:58
@shaheeda-cg shaheeda-cg requested a review from a team as a code owner July 3, 2026 12:58
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens TR-181 handling for X_RDKCENTRAL-COM_TransitionDisable so it can only be set when the VAP security mode is WPA3-Personal-Transition, preventing invalid configuration changes in other modes.

Changes:

  • Added a security-mode gate before applying updates to wpa3_transition_disable.
  • Added error logging and rejected SET attempts when the current security mode is not WPA3-Personal-Transition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/dml/tr_181/ml/cosa_wifi_dml.c
Comment thread source/dml/tr_181/ml/cosa_wifi_dml.c Outdated
@shaheeda-cg

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

…security modes other than WPA3-Personal-Transition

Added security mode validation before updating TransitionDisable parameter
Restricted TransitionDisable SET operation to WPA3-Personal-Transition mode only
Added error logging for invalid SET requests in unsupported security modes
Prevented configuration updates when the current security mode does not support TransitionDisable
This ensures TransitionDisable parameter is accepted only for WPA3-Personal-Transition security mode, aligning behavior with expected functionality and preventing invalid configuration changes.
Signed-off-by:
Shaik, Shaheeda shaheeda.shaik@capgemini.com
Sangram Babar, Snehal snehal.sangram-babar@capgemini.com
@shaheeda-cg shaheeda-cg force-pushed the fix_wpa3_transition_disable_issue branch from 7289a43 to 0d77205 Compare July 6, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants