BCOMB-3480: Client connectivity drop due to Gateway blocking Unencrypted frames#1245
Open
Raju-krish wants to merge 1 commit into
Open
BCOMB-3480: Client connectivity drop due to Gateway blocking Unencrypted frames#1245Raju-krish wants to merge 1 commit into
Raju-krish wants to merge 1 commit into
Conversation
…ted frames Reason for change : DHCP discover gets dropped because STA sends it without encryption. Proposed Fix : Disassociate the client if it doesn't have IP Test Proceedure : 1) If STA sends unprotected frame without having IP should disassociate. Priority: P0 Risks: Low Signed-off-by: Rajagopalaswamy M <mrajagopalaswamy@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a client connectivity issue where unencrypted frames (notably DHCP Discover) are dropped by triggering a client disassociation when the client has not yet obtained an IP address, allowing the client to reconnect and retry DHCP successfully.
Changes:
- Added a new Wi-Fi HAL callback handler for “frame dropped due to being unencrypted”.
- Implemented logic to disassociate a client when an unencrypted frame is dropped and the client has no IP.
- Registered the new HAL callback during Wi-Fi monitor initialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mac_address_t sta_mac; | ||
| char cli_ip_str[IP_STR_LEN] = { 0 }; | ||
| char cli_interface_str[IFNAMSIZ] = { 0 }; | ||
| const int reason = 2; |
Comment on lines
+3388
to
+3396
| /* Only force a disassoc when the STA has no IPv4 yet, where the | ||
| * unprotected frames are blocking DHCP from ever succeeding. */ | ||
| if (csi_getClientIpAddress(src_mac, cli_ip_str, cli_interface_str, 1) == 0 && | ||
| cli_ip_str[0] != '\0') { | ||
| wifi_util_info_print(WIFI_MON, | ||
| "%s:%d: [FC_WEP] client[%s] has IPv4 %s on %s - no action\n", | ||
| __func__, __LINE__, src_mac, cli_ip_str, cli_interface_str); | ||
| return 0; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change : DHCP discover gets dropped because STA sends it without encryption.
Proposed Fix : Disassociate the client if it doesn't have IP
Test Proceedure : 1) If STA sends unprotected frame without having IP should disassociate.
Priority: P0
Risks: Low