RDKB-65825: RFC Enabled By Default#1239
Open
navyasher wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates OneWiFi’s default configuration so certain fully deployed RFC features are enabled by default (notably WiFi Interworking, Passpoint, and 2G 802.11ax), and aligns related database defaults/schema versioning to persist those defaults.
Changes:
- Enable default RFC values for WiFi Interworking and Passpoint when PSM values are absent.
- Change DB-side RFC defaults to enable Interworking/Passpoint and make 2G 802.11ax enabled by default (including an upgrade/override path).
- Update WHIX log interval default and bump the OVSDB schema version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/dml/tr_181/ml/cosa_wifi_internal.c | Changes default Interworking/Passpoint RFC values from disabled to enabled when PSM keys are missing. |
| source/db/wifi_db_apis.c | Updates RFC defaults, WHIX log interval default, and adds RFC override/upgrade helper logic for 2G 11ax enablement. |
| config/rdkb-wifi.ovsschema | Bumps OVSDB schema version to 1.00.052. |
Comments suppressed due to low confidence (1)
source/db/wifi_db_apis.c:4914
- The WhixLoginterval upgrade logic is no longer gated by db_version, so every call to wifidb_global_config_upgrade() will re-read from PSM (or reset to DEFAULT_WHIX_LOGINTERVAL) and can overwrite the DB value repeatedly. This breaks the one-time "upgrade" contract used by the other upgrade blocks below.
memset(strValue, 0, sizeof(strValue));
str = (char *)p_ccsp_desc->psm_get_value_fn(WhixLoginterval, strValue, sizeof(strValue));
if (str != NULL) {
g_wifidb->global_config.global_parameters.whix_log_interval = atoi(str);
wifi_util_dbg_print(WIFI_DB, "whix_log_interval is %d and str is %s \n",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: RFC Enabled By Default on fully deployed RFCs Test Procedure: Below parameters should be set to respective default value Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.WifiClient.ActiveMeasurements.Enable Device.DeviceInfo.X_RDKCENTRAL-COM_WIFI_TELEMETRY.LogInterval Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.WiFi-Interworking.Enable Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.WiFi-Passpoint.Enable Device.WiFi.2G80211axEnable Risks: None Signed-off-by: Navya_Sheregar@comcast.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: RFC Enabled By Default on fully deployed RFCs
Test Procedure: Below parameters should be set to respective default value Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.WifiClient.ActiveMeasurements.Enable Device.DeviceInfo.X_RDKCENTRAL-COM_WIFI_TELEMETRY.LogInterval Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.WiFi-Interworking.Enable Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.WiFi-Passpoint.Enable Device.WiFi.2G80211axEnable
Risks: None
Signed-off-by: Navya_Sheregar@comcast.com