RDKB-65508, RDKB-65530: Crash with cJSON_Delete as signature#1236
Open
Raju-krish wants to merge 1 commit into
Open
RDKB-65508, RDKB-65530: Crash with cJSON_Delete as signature#1236Raju-krish wants to merge 1 commit into
Raju-krish wants to merge 1 commit into
Conversation
Reason for change: Crash occurs because of accessing dangling pointer. Test Procedure: Build should be successful, Crash shouldn't occur. Risks: Low Priority: P1 Signed-off-by: Rajagopalaswamy M <mrajagopalaswamy@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash caused by accessing freed cJSON nodes after schema parsing by avoiding reference-based merges when resolving $ref (the parsed root schema is deleted at the end of parsing, so referenced nodes can become dangling).
Changes:
- Replace
cJSON_AddItemReferenceToObject()with a deep copy (cJSON_Duplicate(..., 1)) when merging referenced schema nodes into a base object.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+181
to
+184
| cJSON* copy = cJSON_Duplicate(child, 1); | ||
| if (copy) { | ||
| cJSON_AddItemToObject(base, child->string, copy); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Crash occurs because of accessing dangling pointer.
Test Procedure: Build should be successful, Crash shouldn't occur.
Risks: Low
Priority: P1