RDKB-64347: Fixing coverity issues#1219
Open
bharathivelp wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets low-priority Coverity findings across OneWifi by replacing unsafe string operations and tightening memory/buffer handling in validation and sample/test paths.
Changes:
- Replaced several
strcpy/copy_stringusages with boundedsnprintfto avoid overflows in config validation and DML defaults. - Improved buffer-safety in MAC filter index list building (avoids
strcatoverflow). - Refactored sample webconfig consumer cleanup to use
webconfig_data_free()and added some NULL-guards (though a few NULL-deref paths remain).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| source/utils/wifi_validator.c | Safer bounded copies for ANQP, interworking, radius, and global config string fields. |
| source/sampleapps/webconfig_consumer_apis.c | Cleanup changes using webconfig_data_free(); some call-sites updated to gate on str != NULL. |
| source/dml/wifi_ssp/ssp_loop.c | Prevents index_list overflow when concatenating MAC filter index instances. |
| source/dml/dml_webconfig/dml_onewifi_api.c | Replaces strcpy with bounded snprintf for WPS PIN defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Fixing Low priority Coverity issue. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: Velpula_Bharathi@comcast.com
bharathivelp
force-pushed
the
RDKB-63347_Coverity_fixes
branch
from
d9b8a8d to
c0007af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing Low priority Coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
Risks: Low
Priority: P1
Signed-off-by: Velpula_Bharathi@comcast.com