RDKB-65811: Update DML cache if HAL params change#1133
Open
bmilcz-comcast wants to merge 2 commits into
Open
Conversation
bmilcz-comcast
force-pushed
the
dml_cache_updates_fix
branch
from
a4da566 to
9641ce3
Compare
This was referenced May 21, 2026
bmilcz-comcast
force-pushed
the
dml_cache_updates_fix
branch
from
9641ce3 to
d0fcfd4
Compare
bmilcz-comcast
force-pushed
the
dml_cache_updates_fix
branch
2 times, most recently
from
21727c4 to
719a442
Compare
bmilcz-comcast
changed the title
bmilcz-comcast
force-pushed
the
dml_cache_updates_fix
branch
3 times, most recently
from
fa97d7e to
a94afac
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to keep the manager/global caches and the DML cache consistent when HAL mutates VAP parameters after an apply path completes (notably for _PLATFORM_BANANAPI_R4_), so subsequent WebConfig/DML reads reflect the true applied state.
Changes:
- Adds a shared
update_global_cache()implementation inwifi_ctrl.c(and exposes it viawifi_ctrl.h) to sync WifiDB/global VAP caches from a target VAP map. - Introduces BananaPi-specific logic in several apply/update flows to detect post-apply HAL mutations and trigger a DML subdoc encode to refresh DML cache.
- Fixes RBUS publish payload length by setting
raw_data_lenfor a DML-init event publish.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| source/core/wifi_ctrl.h | Exposes new cache update helpers (update_global_cache, BananaPi-only update_dml_cache). |
| source/core/wifi_ctrl.c | Adds update_global_cache() and BananaPi-only update_dml_cache() implementation. |
| source/core/wifi_ctrl_webconfig.c | BananaPi-only detection of post-apply HAL mutations and triggering DML cache refresh. |
| source/core/wifi_ctrl_rbus_handlers.c | Sets raw_data_len for a DML-init RBUS event publish. |
| source/core/wifi_ctrl_queue_handlers.c | BananaPi-only DML cache refresh triggering in multiple queue-handler flows. |
| source/core/services/vap_svc.c | Removes local update_global_cache and adds BananaPi-only DML cache refresh triggering in VAP start/stop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bmilcz-comcast
force-pushed
the
dml_cache_updates_fix
branch
2 times, most recently
from
9bec572 to
c9f77c2
Compare
bmilcz-comcast
changed the title
bmilcz-comcast
force-pushed
the
dml_cache_updates_fix
branch
from
c9f77c2 to
26be21d
Compare
Using WebConfig we are synchronizing the current manager cache with DML cache if params that were passed down to createVAP() change after the function finalizes. Signed-off-by: Brayan Milczarek <brayan_milczarek@comcast.com>
bmilcz-comcast
force-pushed
the
dml_cache_updates_fix
branch
from
26be21d to
7bbccb6
Compare
Comment on lines
+1069
to
+1073
| if (dml_cache_update_needed) { | ||
| webconfig_init_subdoc_data(dml_cache_update_subdoc); | ||
| update_dml_cache(ctrl, dml_cache_update_subdoc); | ||
| } | ||
| free(dml_cache_update_subdoc); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using WebConfig we are synchronizing the current manager cache with DML cache if params that were passed down to createVAP() change after the funcion finalizes.