RDKBWIFI-442: Beacon measurements collection from the associated STA by Nikita-Hakai · Pull Request #1130 · rdkcentral/OneWifi

Nikita-Hakai · 2026-05-13T21:50:32Z

Collection of Beacon measurement report from the associated STA

Copilot

Pull request overview

Adds EasyMesh beacon-query/report plumbing so the EM app can request beacon measurements from associated STAs, process RRM measurement reports, encode/decode beacon report payloads, and translate them into EasyMesh STA info.

Changes:

Adds Device.WiFi.EM.BeaconQuery handling and RRM action-frame send/receive paths.
Changes beacon report payload storage from a fixed array to dynamically allocated data.
Updates beacon report encoding/decoding and EasyMesh translation logic.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`source/webconfig/wifi_webconfig_beacon_report.c`	Frees prior dynamic beacon report data before decoding a new report.
`source/webconfig/wifi_encoder.c`	Dynamically allocates the hex string used to encode report data.
`source/webconfig/wifi_easymesh_translator.c`	Finds BSS by `vap_index` and copies beacon report data into EasyMesh STA info.
`source/webconfig/wifi_decoder.c`	Allocates beacon report data from decoded `FrameLen` and decodes hex report data.
`source/core/wifi_ctrl.c`	Routes radio measurement action frames to the beacon report event subtype.
`source/apps/em/wifi_em.h`	Adds beacon query namespace and EM data fields.
`source/apps/em/wifi_em.c`	Adds beacon query sending, RRM beacon report parsing/publishing, and bus registration.
`include/wifi_base.h`	Adds beacon query params and changes beacon report data to a pointer.

Comments suppressed due to low confidence (4)

source/apps/em/wifi_em.c:935

The HAL result is ignored. If wifi_hal_setRMBeaconRequest fails, the function still logs a dialog token and returns success, so the controller gets no indication that the beacon request was not transmitted.

    wifi_hal_setRMBeaconRequest(ap_index, query->sta_mac, params, &out_dialog);
    wifi_util_dbg_print(WIFI_EM, "%s:%d: dialogue token is %d\n", __func__, __LINE__, out_dialog);

source/webconfig/wifi_decoder.c:6284

This new allocation is not released by the generic webconfig_data_free cleanup path, which currently only frees u.encoded.raw. Successful beacon-report decodes will therefore leak the report buffer unless this ownership is added to cleanup or freed after translation.

    sta_data->data = (unsigned char *)malloc(sta_data->data_len);
    if (sta_data->data == NULL) {
        wifi_util_error_print(WIFI_WEBCONFIG, "%s:%d: failed to allocate %u bytes for report data\n",
            __func__, __LINE__, sta_data->data_len);
        return webconfig_error_decode;

source/webconfig/wifi_decoder.c:6287

If ReportData is missing or invalid, decode_param_string returns immediately from the function and bypasses the free for sta_data->data, leaking the buffer allocated above.

    decode_param_string(obj_sta_cfg, "ReportData", param);

source/webconfig/wifi_decoder.c:6289

stringtohex only checks that the output buffer is large enough for the input string; it does not require ReportData to contain exactly FrameLen * 2 hex characters. With the new malloc'd buffer, a short hex string leaves the remaining bytes uninitialized and those bytes can be forwarded/encoded as part of the report.

    out_ptr = stringtohex(strlen(param->valuestring), param->valuestring, sta_data->data_len,
        sta_data->data);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ated STA

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

+        if (p_data->data_type != bus_data_type_bytes) {
+        wifi_util_error_print(WIFI_EM, "%s:%d: Invalid Received:%s data type:%x\n",
+
+                __func__, __LINE__, event_name, p_data->data_type);
+        return bus_error_invalid_input;
+    }


+    free(wb_data->u.decoded.sta_beacon_report.data);
+    wb_data->u.decoded.sta_beacon_report.data = NULL;
+
    memset(&p_data, 0, sizeof(raw_data_t));

    p_data.data_type = bus_data_type_string;


Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

+    //now create map for response and send
+    if (em_send_action_frame(p_data->raw_data.bytes) != RETURN_OK) {
+        wifi_util_error_print(WIFI_EM, "%s:%d: Failed to send beacon query action frame\n",
+            __func__, __LINE__);
+        return bus_error_general;
+    }


+static bus_error_t send_beacon_query(char *event_name, raw_data_t *p_data, void *userData)
+{
+    if (strcmp(event_name, WIFI_EM_BEACON_QUERY) != 0) {
+        wifi_util_error_print(WIFI_EM, "%s:%d Not EasyMesh beacon query event, %s\n", __func__, __LINE__, event_name);
+        return bus_error_invalid_namespace;
+    }


+    free(wb_data->u.decoded.sta_beacon_report.data);
+    wb_data->u.decoded.sta_beacon_report.data = NULL;
+
    memset(&p_data, 0, sizeof(raw_data_t));

    p_data.data_type = bus_data_type_string;


github-actions Bot added the community contribution Contributions from community. label May 13, 2026

Nikita-Hakai force-pushed the beacon_metrics branch 3 times, most recently from 5f0c136 to c5ac862 Compare May 14, 2026 17:27

Nikita-Hakai marked this pull request as ready for review May 14, 2026 18:00

Nikita-Hakai requested a review from a team as a code owner May 14, 2026 18:00

Copilot AI review requested due to automatic review settings May 14, 2026 18:00

Copilot started reviewing on behalf of Nikita-Hakai May 14, 2026 18:00 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread source/apps/em/wifi_em.c Outdated

Comment thread source/apps/em/wifi_em.c

Comment thread source/apps/em/wifi_em.c

Comment thread source/apps/em/wifi_em.c Outdated

Comment thread source/webconfig/wifi_decoder.c

Nikita-Hakai changed the title ~~Beacon metrics~~ RDKBWIFI-442: Beacon measurements collection from the associated STA May 14, 2026

Nikita-Hakai force-pushed the beacon_metrics branch from c5ac862 to 3a33f4a Compare May 18, 2026 18:13

RDKBWIFI-442: Collection of Beacon measurement report from the associ…

6cf8d7b

…ated STA

Copilot AI review requested due to automatic review settings May 20, 2026 18:11

Nikita-Hakai force-pushed the beacon_metrics branch from 3a33f4a to 6cf8d7b Compare May 20, 2026 18:11

Copilot started reviewing on behalf of Nikita-Hakai May 20, 2026 18:12 View session

Nikita-Hakai mentioned this pull request May 20, 2026

Beacon metrics. rdkcentral/unified-wifi-mesh#679

Open

Copilot AI reviewed May 20, 2026

View reviewed changes

Merge branch 'develop' into beacon_metrics

3046aaf

Copilot AI review requested due to automatic review settings June 22, 2026 23:01

Copilot started reviewing on behalf of Nikita-Hakai June 22, 2026 23:02 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

Comment thread include/wifi_base.h

Comment thread source/apps/em/wifi_em.c

Comment thread source/webconfig/wifi_decoder.c Outdated

Addressing review comments

10c2572

Nikita-Hakai force-pushed the beacon_metrics branch from 872858e to 10c2572 Compare June 23, 2026 00:32

Merge branch 'develop' into beacon_metrics

e275fd1

Copilot AI review requested due to automatic review settings June 25, 2026 23:36

Copilot started reviewing on behalf of Nikita-Hakai June 25, 2026 23:37 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Nikita-Hakai added 2 commits June 29, 2026 11:44

Merge branch 'develop' into beacon_metrics

98d2ce4

Resolve bssid details from EM agent for MLO clients

be2845e

Copilot AI review requested due to automatic review settings July 3, 2026 07:54

Copilot started reviewing on behalf of Nikita-Hakai July 3, 2026 07:55 View session

Copilot AI reviewed Jul 3, 2026

View reviewed changes

Merge branch 'develop' into beacon_metrics

9f4a88c

Uh oh!

Conversation

Nikita-Hakai commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Nikita-Hakai commented May 13, 2026 •

edited

Loading