Conversation
valasatava
requested changes
Sep 4, 2026
valasatava
left a comment
valasatava
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @brindakv. Just few comments
| } | ||
| ] | ||
| }, | ||
| "uniprot_generic_ptm_accession": {}, |
Collaborator
There was a problem hiding this comment.
This attribute and the one below miss schema definitions
| "context": "dictionary" | ||
| }, | ||
| { | ||
| "text": "Modified Residue Part", |
Collaborator
There was a problem hiding this comment.
Let's not add this to UI in this first iteration. We had some doubts when we discussed. Thanks!
Contributor
Author
There was a problem hiding this comment.
Thanks @valasatava. Do you still want it indexed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
pdbx_modification_featureandpdbx_chem_comp_pcmpdbx_vrpt_summary_entity_fit_to_mapfrompdbx_core_nonpolymer_entity_instanceschemamodified_monomerpolymer entity feature tonon_standard_monomerfeature