Skip to content

Fix KeyError in verify_payment_link_signature on incomplete payload #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gottostartsomewhere wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix KeyError in verify_payment_link_signature on incomplete payload #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion razorpay/utility/utility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ def verify_payment_signature(self, parameters):

def verify_payment_link_signature(self, parameters):

if 'razorpay_payment_id' in parameters.keys() and 'payment_link_reference_id' in parameters.keys() and 'payment_link_status' in parameters.keys():
required_keys = ('razorpay_payment_id', 'payment_link_id',
'payment_link_reference_id', 'payment_link_status',
'razorpay_signature')
if all(key in parameters for key in required_keys):
payment_id = str(parameters['razorpay_payment_id'])
payment_link_id = str(parameters['payment_link_id'])
payment_link_reference_id = str(parameters['payment_link_reference_id'])
Expand Down
15 changes: 15 additions & 0 deletions tests/test_client_utility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,21 @@ def test_verify_payment_link_signature(self):
self.client.utility.verify_payment_link_signature(parameters),
True)

@responses.activate
def test_verify_payment_link_signature_missing_key(self):
# A payload missing a required key (here payment_link_id) must return
# False, not raise KeyError.
parameters = {}
parameters['razorpay_payment_id'] = 'pay_IH3d0ara9bSsjQ'
parameters['payment_link_reference_id'] = 'TSsd1989'
parameters['payment_link_status'] = 'paid'
parameters['razorpay_signature'] = 'deadbeef'
parameters['secret'] = 'EnLs21M47BllR3X8PSFtjtbd'

self.assertEqual(
self.client.utility.verify_payment_link_signature(parameters),
False)

@responses.activate
def test_verify_payment_signature_with_exception(self):
parameters = {}
Expand Down