Skip to content

[rayci] 0 retries for exit code 42 (test failures) #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliot-barn merged 1 commit into from
Jun 16, 2026
Merged

[rayci] 0 retries for exit code 42 (test failures) #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions raycicmd/bk_pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,12 +246,13 @@ func makeRayDockerPlugin(
}

// makeAutomaticRetryConfig creates the retry configuration for rayci pipelines.
// The retry configuration is to retry once for any unknown exit status or
// test failures, and to retry 3 times for known exit statuses.
// The retry configuration is to retry once for any unknown exit status and to
// retry 3 times for known exit statuses. Test failures (exit_status 42) are not
// retried here since bazel already retries those.
func makeAutomaticRetryConfig(exitStatus []int) []any {
m := []any{
map[string]int{"exit_status": 1, "limit": 1}, // unknown exist status
map[string]int{"exit_status": 42, "limit": 1}, // test failures
map[string]int{"exit_status": 1, "limit": 1}, // unknown exist status

@gemini-code-assist gemini-code-assist Bot Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a small typo in the inline comment: "exist status" should be "exit status" to match the terminology used elsewhere in the function.

Suggested change
map[string]int{"exit_status": 1, "limit": 1}, // unknown exist status
map[string]int{"exit_status": 1, "limit": 1}, // unknown exit status

@sai-miduthuri sai-miduthuri Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

// exit_status 42 (test failures) omitted: bazel already retries those.
}
for _, s := range exitStatus {
m = append(m, map[string]any{"exit_status": s, "limit": 3})
Expand Down
Loading