[History Server][CI] add unit tests for the list API filters - #5238
Open
wuallen57730 wants to merge 1 commit into
Open
[History Server][CI] add unit tests for the list API filters#5238wuallen57730 wants to merge 1 commit into
wuallen57730 wants to merge 1 commit into
Conversation
Signed-off-by: wuallen57730 <yuwu11926@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR worked on unit tests for
historyserver/pkg/utils/filter.go.It adds table-driven tests for the query parameter parsing (
ParseOptionsFromReq,getFiltersFromReq,parsePredicate) and the filtering itself (ApplyTaskFilters,ApplyFilter), covering the defaults, the limit bounds, the rejection paths, and the ordering and truncation that the list endpoints rely on. No production code is changed.Code coverage result
Code coverage of
pkg/utils/filter.gois increased from 0.0% to 98.8% (83 of 84 statements). Overall code coverage ofpkg/utilsis increased from 27.3% to 46.2%.The one uncovered statement is
default: unsupported type %Tin theparseclosure, which is unreachable because the closure is only called with*intand*bool.Related issue number
Part of #5222
Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Tests run
go test -count=1 -race ./pkg/utils/